Merge pull request #6236 from nextcloud/dependabot/composer/nextcloud…

…/coding-standard-1.2.3
nextcloud · Aug 26, 2024 · 2233786 · 2233786
2 parents 2d2f7c6 + ba3e97b
commit 2233786
Show file tree

Hide file tree

Showing 42 changed files with 136 additions and 136 deletions.
diff --git a/composer.lock b/composer.lock
diff --git a/lib/Activity/Filter.php b/lib/Activity/Filter.php
@@ -39,8 +39,8 @@ public function getName(): string {
 
 	/**
 	 * @return int whether the filter should be rather on the top or bottom of
-	 * the admin section. The filters are arranged in ascending order of the
-	 * priority values. It is required to return a value between 0 and 100.
+	 *             the admin section. The filters are arranged in ascending order of the
+	 *             priority values. It is required to return a value between 0 and 100.
 	 * @since 11.0.0
 	 */
 	public function getPriority(): int {

diff --git a/lib/Activity/SettingBase.php b/lib/Activity/SettingBase.php
@@ -47,8 +47,8 @@ public function getName(): string {
 
 	/**
 	 * @return int whether the filter should be rather on the top or bottom of
-	 * the admin section. The filters are arranged in ascending order of the
-	 * priority values. It is required to return a value between 0 and 100.
+	 *             the admin section. The filters are arranged in ascending order of the
+	 *             priority values. It is required to return a value between 0 and 100.
 	 * @since 11.0.0
 	 */
 	public function getPriority(): int {

diff --git a/lib/Activity/SettingChanges.php b/lib/Activity/SettingChanges.php
@@ -25,8 +25,8 @@ public function getName(): string {
 
 	/**
 	 * @return int whether the filter should be rather on the top or bottom of
-	 * the admin section. The filters are arranged in ascending order of the
-	 * priority values. It is required to return a value between 0 and 100.
+	 *             the admin section. The filters are arranged in ascending order of the
+	 *             priority values. It is required to return a value between 0 and 100.
 	 * @since 11.0.0
 	 */
 	public function getPriority(): int {

diff --git a/lib/AppInfo/Application.php b/lib/AppInfo/Application.php
@@ -176,7 +176,7 @@ public function registerCommentsEntity(IEventDispatcher $eventDispatcher): void
 				$permissionService = $this->getContainer()->get(PermissionService::class);
 
 				try {
-					return $permissionService->checkPermission($cardMapper, (int) $name, Acl::PERMISSION_READ);
+					return $permissionService->checkPermission($cardMapper, (int)$name, Acl::PERMISSION_READ);
 				} catch (\Exception $e) {
 					return false;
 				}

diff --git a/lib/Capabilities.php b/lib/Capabilities.php
@@ -14,7 +14,7 @@ class Capabilities implements ICapability {
 
 	/** @var IAppManager */
 	private $appManager;
-	/**  @var PermissionService */
+	/** @var PermissionService */
 	private $permissionService;
 
 

diff --git a/lib/Command/TransferOwnership.php b/lib/Command/TransferOwnership.php
@@ -72,17 +72,17 @@ protected function execute(InputInterface $input, OutputInterface $output): int
 		try {
 			$board = $boardId ? $this->boardMapper->find($boardId) : null;
 		} catch (\Exception $e) {
-			$output->writeln("Could not find a board for the provided id.");
+			$output->writeln('Could not find a board for the provided id.');
 			return 1;
 		}
 
 		if ($boardId !== null && $board->getOwner() !== $owner) {
-			$output->writeln("$owner is not the owner of the board $boardId (" . $board->getTitle() . ")");
+			$output->writeln("$owner is not the owner of the board $boardId (" . $board->getTitle() . ')');
 			return 1;
 		}
 
 		if ($boardId) {
-			$output->writeln("Transfer board " . $board->getTitle() . " from ". $board->getOwner() ." to $newOwner");
+			$output->writeln('Transfer board ' . $board->getTitle() . ' from '. $board->getOwner() ." to $newOwner");
 		} else {
 			$output->writeln("Transfer all boards from $owner to $newOwner");
 		}
@@ -94,12 +94,12 @@ protected function execute(InputInterface $input, OutputInterface $output): int
 
 		if ($boardId) {
 			$this->boardService->transferBoardOwnership($boardId, $newOwner, $remapAssignment);
-			$output->writeln("<info>Board " . $board->getTitle() . " from ". $board->getOwner() ." transferred to $newOwner completed</info>");
+			$output->writeln('<info>Board ' . $board->getTitle() . ' from '. $board->getOwner() ." transferred to $newOwner completed</info>");
 			return 0;
 		}
 
 		foreach ($this->boardService->transferOwnership($owner, $newOwner, $remapAssignment) as $board) {
-			$output->writeln(" - " . $board->getTitle() . " transferred");
+			$output->writeln(' - ' . $board->getTitle() . ' transferred');
 		}
 		$output->writeln("<info>All boards from $owner to $newOwner transferred</info>");
 

diff --git a/lib/DAV/Calendar.php b/lib/DAV/Calendar.php
@@ -25,7 +25,7 @@ class Calendar extends ExternalCalendar {
 	private $children;
 	/** @var DeckCalendarBackend */
 	private $backend;
-	/**  @var Board */
+	/** @var Board */
 	private $board;
 
 	public function __construct(string $principalUri, string $calendarUri, Board $board, DeckCalendarBackend $backend) {

diff --git a/lib/Db/AclMapper.php b/lib/Db/AclMapper.php
@@ -75,7 +75,7 @@ public function findBoardId($id): ?int {
 		try {
 			$entity = $this->find($id);
 			return $entity->getBoardId();
-		} catch (DoesNotExistException | MultipleObjectsReturnedException $e) {
+		} catch (DoesNotExistException|MultipleObjectsReturnedException $e) {
 		}
 		return null;
 	}

diff --git a/lib/Db/AttachmentMapper.php b/lib/Db/AttachmentMapper.php
@@ -61,9 +61,9 @@ public function find($id) {
 	public function findByData($cardId, $data) {
 		$qb = $this->db->getQueryBuilder();
 		$qb->select('*')
-				->from($this->getTableName())
-				->where($qb->expr()->eq('card_id', $qb->createNamedParameter($cardId, IQueryBuilder::PARAM_INT)))
-				->andWhere($qb->expr()->eq('data', $qb->createNamedParameter($data, IQueryBuilder::PARAM_STR)));
+			->from($this->getTableName())
+			->where($qb->expr()->eq('card_id', $qb->createNamedParameter($cardId, IQueryBuilder::PARAM_INT)))
+			->andWhere($qb->expr()->eq('data', $qb->createNamedParameter($data, IQueryBuilder::PARAM_STR)));
 
 		return $this->findEntity($qb);
 	}

diff --git a/lib/Db/Card.php b/lib/Db/Card.php
@@ -165,7 +165,7 @@ public function getDaysUntilDue(): ?int {
 		$matchDate->setTime(0, 0);
 
 		$diff = $today->diff($matchDate);
-		return (int) $diff->format('%R%a'); // Extract days count in interval
+		return (int)$diff->format('%R%a'); // Extract days count in interval
 	}
 
 	public function getCalendarPrefix(): string {

diff --git a/lib/Db/CardMapper.php b/lib/Db/CardMapper.php
@@ -410,7 +410,7 @@ private function extendQueryByFilter(IQueryBuilder $qb, SearchQuery $query) {
 		foreach ($query->getDuedate() as $duedate) {
 			$dueDateColumn = $this->databaseType === 'sqlite3' ? $qb->createFunction('DATETIME(`c`.`duedate`)') : 'c.duedate';
 			$date = $duedate->getValue();
-			if ($date === "") {
+			if ($date === '') {
 				$qb->andWhere($qb->expr()->isNotNull('c.duedate'));
 				continue;
 			}
@@ -461,7 +461,7 @@ private function extendQueryByFilter(IQueryBuilder $qb, SearchQuery $query) {
 			foreach ($query->getAssigned() as $index => $assignment) {
 				$qb->innerJoin('c', 'deck_assigned_users', 'au' . $index, $qb->expr()->eq('c.id', 'au' . $index . '.card_id'));
 				$assignedQueryValue = $assignment->getValue();
-				if ($assignedQueryValue === "") {
+				if ($assignedQueryValue === '') {
 					$qb->andWhere($qb->expr()->isNotNull('au' . $index . '.participant'));
 					continue;
 				}
@@ -589,7 +589,7 @@ public function findBoardId($id): ?int {
 			}
 			$this->cache->set('findBoardId:' . $id, $result);
 		}
-		return $result !== false ? (int) $result : null;
+		return $result !== false ? (int)$result : null;
 	}
 
 	public function mapOwner(Card &$card) {

diff --git a/lib/Middleware/ExceptionMiddleware.php b/lib/Middleware/ExceptionMiddleware.php
@@ -89,7 +89,7 @@ public function afterException($controller, $methodName, \Exception $exception)
 			];
 			$this->logger->error($exception->getMessage(), ['exception' => $exception]);
 			if ($debugMode === true) {
-				$response['exception'] = (array) $exception;
+				$response['exception'] = (array)$exception;
 			}
 			return new JSONResponse($response, 500);
 		}

diff --git a/lib/Notification/NotificationHelper.php b/lib/Notification/NotificationHelper.php
@@ -142,11 +142,11 @@ public function sendCardAssigned(Card $card, string $userId): void {
 			->setUser($userId)
 			->setDateTime(new DateTime())
 			->setObject('card', (string)$card->getId())
-				->setSubject('card-assigned', [
-					$card->getTitle(),
-					$board->getTitle(),
-					$this->currentUser
-				]);
+			->setSubject('card-assigned', [
+				$card->getTitle(),
+				$board->getTitle(),
+				$this->currentUser
+			]);
 		$this->notificationManager->notify($notification);
 	}
 
@@ -206,9 +206,9 @@ public function sendMention(IComment $comment): void {
 			$notification = $this->notificationManager->createNotification();
 			$notification
 				->setApp('deck')
-				->setUser((string) $mention['id'])
+				->setUser((string)$mention['id'])
 				->setDateTime(new DateTime())
-				->setObject('card', (string) $card->getId())
+				->setObject('card', (string)$card->getId())
 				->setSubject('card-comment-mentioned', [$card->getTitle(), $boardId, $this->currentUser])
 				->setMessage('{message}', ['message' => $comment->getMessage()]);
 			$this->notificationManager->notify($notification);

diff --git a/lib/Reference/BoardReferenceProvider.php b/lib/Reference/BoardReferenceProvider.php
@@ -97,7 +97,7 @@ private function getBoardId(string $url): ?int {
 			preg_match('/^' . preg_quote($startIndex, '/') . '(?:\/#!?)?\/board\/([0-9]+)$/', $url, $matches);
 		}
 		if ($matches && count($matches) > 1) {
-			return (int) $matches[1];
+			return (int)$matches[1];
 		}
 
 		return null;
@@ -106,7 +106,7 @@ private function getBoardId(string $url): ?int {
 	public function getCachePrefix(string $referenceId): string {
 		$boardId = $this->getBoardId($referenceId);
 		if ($boardId !== null) {
-			return (string) $boardId;
+			return (string)$boardId;
 		}
 
 		return $referenceId;

diff --git a/lib/Reference/CardReferenceProvider.php b/lib/Reference/CardReferenceProvider.php
@@ -111,9 +111,9 @@ public function resolveReference(string $referenceText): ?IReference {
 			if ($ids !== null) {
 				[, $cardId] = $ids;
 				try {
-					$card = $this->cardService->find((int) $cardId)->jsonSerialize();
-					$stack = $this->stackService->find((int) $card['stackId'])->jsonSerialize();
-					$board = $this->boardService->find((int) $stack['boardId'])->jsonSerialize();
+					$card = $this->cardService->find((int)$cardId)->jsonSerialize();
+					$stack = $this->stackService->find((int)$card['stackId'])->jsonSerialize();
+					$board = $this->boardService->find((int)$stack['boardId'])->jsonSerialize();
 				} catch (NoPermissionException $e) {
 					// Skip throwing if user has no permissions
 					return null;

diff --git a/lib/Reference/CommentReferenceProvider.php b/lib/Reference/CommentReferenceProvider.php
@@ -73,7 +73,7 @@ public function resolveReference(string $referenceText): ?IReference {
 				try {
 					$card = $this->cardService->find($cardId)->jsonSerialize();
 					$board = $this->boardService->find($boardId)->jsonSerialize();
-					$stack = $this->stackService->find((int) $card['stackId'])->jsonSerialize();
+					$stack = $this->stackService->find((int)$card['stackId'])->jsonSerialize();
 				} catch (NoPermissionException $e) {
 					// Skip throwing if user has no permissions
 					return null;
@@ -162,9 +162,9 @@ private function getIds(string $url): ?array {
 		}
 		if ($matches && count($matches) > 3) {
 			return [
-				(int) $matches[1],
-				(int) $matches[2],
-				(int) $matches[3],
+				(int)$matches[1],
+				(int)$matches[2],
+				(int)$matches[3],
 			];
 		}
 

diff --git a/lib/Service/CommentService.php b/lib/Service/CommentService.php
@@ -65,8 +65,8 @@ public function list(string $cardId, int $limit = 20, int $offset = 0): DataResp
 	private function get(int $cardId, int $commentId): IComment {
 		$this->permissionService->checkPermission($this->cardMapper, $cardId, Acl::PERMISSION_READ);
 		try {
-			$comment = $this->commentsManager->get((string) $commentId);
-			if ($comment->getObjectType() !== Application::COMMENT_ENTITY_TYPE || (int) $comment->getObjectId() !== $cardId) {
+			$comment = $this->commentsManager->get((string)$commentId);
+			if ($comment->getObjectType() !== Application::COMMENT_ENTITY_TYPE || (int)$comment->getObjectId() !== $cardId) {
 				throw new CommentNotFoundException();
 			}
 		} catch (CommentNotFoundException $e) {
@@ -134,7 +134,7 @@ public function update(string $cardId, string $commentId, string $message): Data
 		if (!is_numeric($commentId)) {
 			throw new BadRequestException('A valid comment id must be provided');
 		}
-		$comment = $this->get((int) $cardId, (int) $commentId);
+		$comment = $this->get((int)$cardId, (int)$commentId);
 		if ($comment->getActorType() !== 'users' || $comment->getActorId() !== $this->userId) {
 			throw new NoPermissionException('Only authors are allowed to edit their comment.');
 		}

diff --git a/lib/Service/Importer/BoardImportService.php b/lib/Service/Importer/BoardImportService.php
@@ -404,7 +404,7 @@ public function getData(): \stdClass {
 	 * @return void
 	 */
 	public function setConfig(string $configName, $value): void {
-		if (empty((array) $this->config)) {
+		if (empty((array)$this->config)) {
 			$this->setConfigInstance(new \stdClass);
 		}
 		$this->config->$configName = $value;

diff --git a/lib/Service/Importer/Systems/DeckJsonService.php b/lib/Service/Importer/Systems/DeckJsonService.php
@@ -51,7 +51,7 @@ public function validateUsers(): void {
 			if (!is_string($nextcloudUid) && !is_numeric($nextcloudUid)) {
 				throw new \LogicException('User on setting uidRelation is invalid');
 			}
-			$nextcloudUid = (string) $nextcloudUid;
+			$nextcloudUid = (string)$nextcloudUid;
 			$this->getImportService()->getConfig('uidRelation')->$exportUid = $this->userManager->get($nextcloudUid);
 			if (!$this->getImportService()->getConfig('uidRelation')->$exportUid) {
 				throw new \LogicException('User on setting uidRelation not found: ' . $nextcloudUid);
@@ -106,7 +106,7 @@ public function getCardAssignments(): array {
 	public function getComments(): array {
 		$comments = [];
 		foreach ($this->tmpCards as $sourceCard) {
-			if (!property_exists($sourceCard, "comments")) {
+			if (!property_exists($sourceCard, 'comments')) {
 				continue;
 			}
 			$commentsOriginal = $sourceCard->comments;

diff --git a/lib/Service/Importer/Systems/TrelloJsonService.php b/lib/Service/Importer/Systems/TrelloJsonService.php
@@ -71,7 +71,7 @@ public function validateUsers(): void {
 			if (!is_string($nextcloudUid) && !is_numeric($nextcloudUid)) {
 				throw new \LogicException('User on setting uidRelation is invalid');
 			}
-			$nextcloudUid = (string) $nextcloudUid;
+			$nextcloudUid = (string)$nextcloudUid;
 			$this->getImportService()->getConfig('uidRelation')->$trelloUid = $this->userManager->get($nextcloudUid);
 			if (!$this->getImportService()->getConfig('uidRelation')->$trelloUid) {
 				throw new \LogicException('User on setting uidRelation not found: ' . $nextcloudUid);
@@ -141,7 +141,7 @@ function (\stdClass $a) use ($trelloCard) {
 					$message = $this->l10n->t(
 						"This comment has more than %s characters.\n" .
 						"Added as an attachment to the card with name %s.\n" .
-						"Accessible on URL: %s.",
+						'Accessible on URL: %s.',
 						[
 							IComment::MAX_MESSAGE_LENGTH,
 							'comment_' . $commentId . '.md',