-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 30 design issues #6232
Merged
Merged
fix: 30 design issues #6232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliushaertl
requested changes
Aug 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment, can you please also list the items from the original issue that were addressed in the pr description?
luka-nextcloud
force-pushed
the
fix/nextcloud-30-design-issues
branch
from
August 27, 2024 10:45
bae066e
to
236f64d
Compare
Signed-off-by: Luka Trovic <luka@nextcloud.com>
juliushaertl
force-pushed
the
fix/nextcloud-30-design-issues
branch
from
August 29, 2024 09:34
236f64d
to
4aea39e
Compare
juliushaertl
approved these changes
Aug 29, 2024
Pushed a small fix for the duplicate scrollbar issues ;) |
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliushaertl
force-pushed
the
fix/nextcloud-30-design-issues
branch
from
August 29, 2024 09:36
4aea39e
to
fb54b81
Compare
/backport to stable30 |
/backport to stable30 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things that were addressed
Spacing between a list with scroll bar/no bar is different at the top
Before
After
Should the share icon be white like 3 dot menu -> Migrate to a vue-material-design-icon that picks up the text color
Before
After
3.Board / upcoming card heading has wrong indent
Before
After
Left corners of the card are not round
Before
After
Move card screen issues
Before
After
Card has many scrollbars
Before
After
Card title/input seems to be missing top margin
Before
After