Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 30 design issues #6232

Merged
merged 2 commits into from
Aug 29, 2024
Merged

fix: 30 design issues #6232

merged 2 commits into from
Aug 29, 2024

Conversation

luka-nextcloud
Copy link
Contributor

@luka-nextcloud luka-nextcloud commented Aug 21, 2024

Things that were addressed

  1. Spacing between a list with scroll bar/no bar is different at the top
    Before
    image
    After
    image

  2. Should the share icon be white like 3 dot menu -> Migrate to a vue-material-design-icon that picks up the text color
    Before
    image
    After
    image

3.Board / upcoming card heading has wrong indent
Before
image
After
image

  1. Left corners of the card are not round
    Before
    image
    After
    image

  2. Move card screen issues
    Before
    image
    After
    image

  3. Card has many scrollbars
    Before
    image
    After
    image

  4. Card title/input seems to be missing top margin
    Before
    image
    After
    image

Copy link
Member

@juliushaertl juliushaertl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, can you please also list the items from the original issue that were addressed in the pr description?

src/components/board/Board.vue Outdated Show resolved Hide resolved
Signed-off-by: Luka Trovic <luka@nextcloud.com>
@juliushaertl
Copy link
Member

Pushed a small fix for the duplicate scrollbar issues ;)

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliushaertl juliushaertl merged commit c6c41c5 into main Aug 29, 2024
30 checks passed
@juliushaertl juliushaertl deleted the fix/nextcloud-30-design-issues branch August 29, 2024 10:28
@juliushaertl
Copy link
Member

/backport to stable30

@juliushaertl
Copy link
Member

/backport to stable30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ☑️ Done
Development

Successfully merging this pull request may close these issues.

Nextcloud 30 design issues
2 participants