-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(translationtool): Improve regex for vue translation matching #663
Conversation
nickvergessen
commented
Sep 9, 2024
•
edited
Loading
edited
- Fix bug(l10n): Files are not parsed correctly leading to defect entries at Transifex mijorus/rolls#2
Before | After |
---|---|
Signed-off-by: Joas Schilling <coding@schilljs.com>
It can be done via "ungreed ?" operator.
But anyway, these regexp are ugly. And more of then it repeated 6 times. By the way third regexp is pointless. One slash in php double quotes just escape "everything" and did not make sense in case of "template quote". In the end - why not to do something like |
I don't really know how to review this, it sounds like it requires a test set somehow, also there is this project that deals with string extractions that might be worth considering 🤷 |
Signed-off-by: Joas Schilling <coding@schilljs.com>
That's a cool thing, unluckily most apps are not using Vue3 yet. |
2b42ed6
to
86daddf
Compare
Signed-off-by: Joas Schilling <coding@schilljs.com>
86daddf
to
93eb32e
Compare
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
a023f9c
to
32533a0
Compare
Added some testing as well |
For testing purpose provide
Last one was a joke as incorrect "template quote" in regexp |