-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(entrypoint): add debug mode for entrypoint #2311
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Josh <josh.t.richards@gmail.com>
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Cc: @tzerber You might find this of interest too |
I do like it, neat. Would also help debugging fresh installs like the one we had few weeks(months? can't remember) ago where upon fresh install on slower hardware it was reporting weird errors and the only solution was to down/up the container. Good job! |
This would be an option would work exclusively on the Nextcloud image. |
@J0WI Well, it also turns on verbose mode for rsync and the installer (added in v28: see nextcloud/server#41214) too. Perhaps verbose mode for the installer should on by default in the entrypoint (with or without this PR). After all, updating is already fairly verbose. The installer just isn't by default. It's a one-off event so maybe that's the approach there. Verbose mode for rsync could be helpful in troubleshooting situations that arise with folks with whacky NFS storage/etc. (seems to arise with k8s/helm users most often), but having it on by default doesn't make sense. |
This PR does two things:
IMAGE_DEBUG
) that toggles on a verbose/debug mode for key image functions (entrypoint, install, rsync)Details:
entrypoint.sh
itselfocc maintennace:install
rsync
occ upgrade
didn't need it because it's already fairly verbose by defaultNew retry output:
TODO:
sh
debugging / verbose modeocc maintenance:install
debugging / verbose mode(only adds timestamps so not necessary)occ upgrade
occ
calls (other than the simple ones)?