Add support for AWS Session Token configuration #2364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
Thanks, @refucktor. Will take a closer look when the upstream support is added. May also require some special handling if the upstream support is considered a feature and doesn't get backported to all of the major versions we support. One bit of immediate feedback: this PR needs docs (entry in the appropriate section of the repo README). P.S. Ping this PR one of us doesn't get around to re-looking at this PR after upstream is merged. |
joshtrichards
added
enhancement
feature: auto config (environment variables)
- Introduced logic to handle S3 session token using environment variables. - Supports session token from both a file and direct environment variable. - Defaults to an empty token if no value is provided. Signed-off-by: Hector Valcarcel <hmvalcarcel@gmail.com>
- variable "OBJECTSTORE_S3_SESSION_TOKEN" to support AWS STS auth workflow Signed-off-by: Hector Valcarcel <hmvalcarcel@gmail.com>
refucktor
force-pushed
the
feat/support-aws-session-token
branch
from
7928e7a to
ecbd2ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary