Skip to content

Commit

Permalink
Merge pull request #12130 from nextcloud/docs/json-response-encode-flags
Browse files Browse the repository at this point in the history
feat(developer): Document new encode flags for JSONResponse
  • Loading branch information
Pytal authored Sep 3, 2024
2 parents 5e3d014 + 7f31f70 commit 3d7630b
Showing 1 changed file with 4 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ Front-end changes

Clickable area
^^^^^^^^^^^^^^
The size of the CSS variable ``--clickable-area`` variable has shrunk from ``44px`` to ``34px``.
The size of the CSS variable ``--clickable-area`` variable has shrunk from ``44px`` to ``34px``.
This will result in several regressions and paper-cuts in your app that will need to be manually fixed.
It's recommended to:

Expand All @@ -46,8 +46,8 @@ It's recommended to:

Line height
^^^^^^^^^^^
The ``--default-line-height`` variable has changed from ``24px``` to ``1.5`` for the ``--default-font-size`` this
means that the actual value in pixel will go from 24 to 22.5. Although this is a slight change, it's recommended
The ``--default-line-height`` variable has changed from ``24px``` to ``1.5`` for the ``--default-font-size`` this
means that the actual value in pixel will go from 24 to 22.5. Although this is a slight change, it's recommended
to check for visual regressions in your app.


Expand Down Expand Up @@ -194,6 +194,7 @@ Added APIs
- ``OCP\AppFramework\Bootstrap\IRegistrationContext::registerTaskProcessingTaskType()`` was added to allow registering task processing task types
- ``OCP\Files\IRootFolder::getAppDataDirectoryName()`` was added to allow getting the name of the app data directory
- ``OCP\Security\IHasher::validate()`` should return true if the passed string is a valid hash generated by ``OCP\Security\IHasher::hash()``
- ``OCP\AppFramework\Http\JSONResponse()`` constructor now supports passing additional ``json_encode`` flags, see https://www.php.net/manual/en/function.json-encode.php for details

Changed APIs
^^^^^^^^^^^^
Expand Down

0 comments on commit 3d7630b

Please sign in to comment.