Removed the duplicate extension "js" warning from the NGINX configuration#10408
Removed the duplicate extension "js" warning from the NGINX configuration#10408susnux merged 1 commit intonextcloud:masterfrom
Conversation
|
Hi @susnux, I've rebased the latest Kind regards, |
|
the rebase went wrong unfortunately |
susnux
left a comment
There was a problem hiding this comment.
LGTM, I fixed the rebase (you accidentally merged the master branch in resulted in duplicated commits)
|
@acataluddi but before we can merge this you need to sign you commit. (pull and |
Hi @susnux, done. Kind regards, |
|
@nickvergessen you accidentally dropped the sign-off |
|
I used the Github button "Update branch". |
msundin
left a comment
There was a problem hiding this comment.
Tested ok that this removes the warning.
|
Hi @acataluddi - seems the signoff was dropped. Can you please checkout your branch, do a pull, rebase on current master and do git commit --amend -s? |
Hi Anna, I've signed off all the commits and pushed the branch for a second review. Kind regards, |
…tion. Fixed #1 Signed-off-by: Adriano Cataluddi <acataluddi@gmail.com>
The current NGINX configuration triggers the following warning