feat: allow cloning archived forms #2490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chartman123
added
enhancement
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2490 +/- ##
============================================
+ Coverage 43.43% 43.44% +0.01%
Complexity 881 881
============================================
Files 75 75
Lines 3357 3358 +1
============================================
+ Hits 1458 1459 +1
Misses 1899 1899 |
Chartman123
force-pushed
the
enh/clone-archived-form
branch
from
bf0fc08 to
50f1d75
Compare
susnux
reviewed
Jan 14, 2025
This makes sure that a cloned form is always in active state and doesn't expire Signed-off-by: Christian Hartmann <chris-hartmann@gmx.de>
This enables the clone button for archived forms and emits the neccessary events to Forms.vue Signed-off-by: Christian Hartmann <chris-hartmann@gmx.de>
Chartman123
force-pushed
the
enh/clone-archived-form
branch
from
50f1d75 to
8b994f8
Compare
susnux
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #2019 by showing the button and handling the events in the frontend and by adjusting the backend to unset the state of the cloned form. It also adds a change to unset the expires timestamp when a form gets cloned.