Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improve compatibility with Windows for uploaded files #2513

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

Koc
Copy link
Collaborator

@Koc Koc commented Jan 23, 2025

Fixes #2409

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.43%. Comparing base (19feceb) to head (1c1d65e).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2513   +/-   ##
=========================================
  Coverage     43.43%   43.43%           
  Complexity      882      882           
=========================================
  Files            77       77           
  Lines          3361     3361           
=========================================
  Hits           1460     1460           
  Misses         1901     1901           

@Koc Koc force-pushed the bugfix/improve-windows-compatibility branch from ecdefa9 to 556303e Compare January 23, 2025 01:08
lib/Service/FormsService.php Outdated Show resolved Hide resolved
@Koc Koc force-pushed the bugfix/improve-windows-compatibility branch 4 times, most recently from c7fdda8 to 3859656 Compare January 29, 2025 15:23

This comment was marked as off-topic.

@Chartman123 Chartman123 added bug Something isn't working php PHP related ticket 3. to review Waiting for reviews labels Feb 19, 2025
@Chartman123 Chartman123 added this to the 5.0 milestone Feb 19, 2025
@Chartman123
Copy link
Collaborator

/backport to stable4

@backportbot backportbot bot added the backport-request Pending backport by the backport-bot label Feb 19, 2025
Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
@Koc Koc force-pushed the bugfix/improve-windows-compatibility branch from 3859656 to 1c1d65e Compare February 19, 2025 23:40
@Koc Koc merged commit c4fa049 into main Feb 19, 2025
53 of 54 checks passed
@Koc Koc deleted the bugfix/improve-windows-compatibility branch February 19, 2025 23:46
Copy link

backportbot bot commented Feb 19, 2025

The backport to stable4 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable4
git pull origin stable4

# Create the new backport branch
git checkout -b backport/2513/stable4

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 1c1d65e8

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/2513/stable4

Error: Failed to cherry pick commits: error: no cherry-pick or revert in progress
fatal: cherry-pick failed


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews backport-request Pending backport by the backport-bot bug Something isn't working feedback-requested php PHP related ticket
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Forms folder structure is not sanitized which can lead to synchronization issues when uploading files
3 participants