Conversation
Chartman123
force-pushed
the
chore/nc-vue-8.25
branch
3 times, most recently
from
5e0d119 to
64ca5d6
Compare
Chartman123
force-pushed
the
chore/nc-vue-8.25
branch
from
64ca5d6 to
c8151c8
Compare
Chartman123
force-pushed
the
chore/nc-vue-8.25
branch
2 times, most recently
from
e9b3c33 to
ca1fa9e
Compare
Chartman123
changed the title
Chartman123
added
3. to review
There was a problem hiding this comment.
Pull Request Overview
This PR adapts the codebase to changes in the nc-vue library, specifically updating component usage and removing deprecated patterns.
- Replaces
NcSelectcomponents withNcSelectUserscomponents and updates their associated properties - Removes
awaitkeyword from a debounced function call in UserSearchMixin - Replaces deprecated
v-tooltipdirective withtitleattribute for tooltip functionality
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/mixins/UserSearchMixin.js | Removes await from debounced function call |
| src/components/SidebarTabs/TransferOwnership.vue | Updates to NcSelectUsers component with property changes |
| src/components/SidebarTabs/SharingSearchDiv.vue | Updates to NcSelectUsers component and event handling |
| src/components/SidebarTabs/SettingsSidebarTab.vue | Replaces v-tooltip with title attribute |
| src/components/Questions/Question.vue | Replaces v-tooltip with title attribute |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Chartman123
force-pushed
the
chore/nc-vue-8.25
branch
from
ca1fa9e to
81e02f3
Compare
Signed-off-by: Christian Hartmann <chris-hartmann@gmx.de>
Chartman123
force-pushed
the
chore/nc-vue-8.25
branch
from
81e02f3 to
7e5ebcf
Compare
susnux
reviewed
Sep 1, 2025
susnux
approved these changes
Sep 1, 2025
Collaborator
susnux
left a comment
susnux
left a comment
There was a problem hiding this comment.
Code looks good but did not verify all props on the NcUserSelect still exist (see comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Christian Hartmann chris-hartmann@gmx.de