-
Couldn't load subscription status.
- Fork 110
feat: introduce Grid as a new question type #2924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@Koc I wouldn't combine checkbox and radio grids into one single question type, but make it two types like we already have for "normal" checkbox/radio questions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool @Koc! :) The answering view layout could use a bunch more whitespace and padding (possibly using whole width always), but also cc @nimishavijay for review.
|
@Chartman123 Did I understand your correctly that we should have multiple question types here? Not just grid but "Grid - checkboxes", "Grid - radios", "Grid - dropdowns", etc. I thought to create nested menu for question creation. Select "Grid" on a first step and then select input type on a second step. |
Yes, no dropdown grid, but these two:
You can use the same component like QuestionMultiple.vue for checkboxes and radios, so in this case QuestionGrid.vue and depending on the prop forms/src/models/AnswerTypes.js Lines 89 to 90 in 3424510
And I think that we should keep the options as they are defining just the rows. The number of columns and their labels could be stored in |
0a50988 to
7e77590
Compare
Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
7e77590 to
b5af87c
Compare
|
Awesome feature! :) I will personally definitely use this :) So the main screen which can use some design is the table rendering, I tried a first basic version here simulating real questions: What seemed to work:
Other than that some comments while editing:
Additionally I know that trying to align the layout of view and edit mode is something that is desired generally so we can try a similar layout for this question type as a follow up, if you wish :) It would look something like this:
|
|
@nimishavijay Thank you for styling guides, I will work on it soon. @Chartman123 I'd prefer to use options because we need ids to associate selected values with rows/columns. User can rename them, so we need rely on id. Also we need to support more complex scenarios than just radio/checkbox. E.g. matrix of numbers, see screen.
Also we already have components for manage options and this is a great opportunity to reuse them NB! I plan to reopen this PR in upstream instead of my fork. |
|
let's continue in #2945 |




Closes #2606
🚧 Development still in progress
I'm trying to reuse already existent
Optionentity by adding extra columnoptionType=row|column.✔️ Implemented
🔍 Cols/Rows management
🔍 Cols/Rows titles and various input type
🔍 Very basic table rendering
🗒️ Todo