PHPStan

[provokateurin]

TODO:

• fix(AppFramework): Adjust types so PHPStan understands them server#58098
• fix(CirclesManager): Use correct return type for probeCircles circles#2337
• fix(IRegistrationContext): Use SimpleContainer in registerService factory server#58261
• fix(IResult): Use more accurate conditional return type for fetchAll server#58256
• fix(IRegistrationContext): Use IContainer in registerService factory server#58355
• Fix a bunch of typing issues to make PHPStan level 10 happy on groupfolders server#58286
• feat: Expose PHP version IDs icewind1991/nextcloud-version-matrix#3
• Submit and backport bugs that were found separately
• Create GHA workflow
• Increase level even further

[provokateurin]

Still some things to do, but the code changes can be reviewed already.

[CarlSchwan]

I'm not really a fan of removing the stubs. We should make it harder to use private apis not simpler.

[provokateurin]

I'm not really a fan of removing the stubs. We should make it harder to use private apis not simpler.

I get your point, but I'm not sure if this is the right way.

Anyway PHPStan has support for stubs, but doesn't like the currently generated ones. I tried a bit, but wasn't able to generate something it accepted. I will have another look again, as this also makes CI easier (no need to clone server and circles).