fix: sorting for older grouping #11691
Conversation
Signed-off-by: greta <gretadoci@gmail.com>
Signed-off-by: greta <gretadoci@gmail.com>
| const groupOrder = sortOrder === 'newest' | ||
| ? ['lastHour', 'today', 'yesterday', 'lastWeek', 'lastMonth', 'older'] | ||
| : ['older', 'lastMonth', 'lastWeek', 'yesterday', 'today', 'lastHour'] |
There was a problem hiding this comment.
for sorting by oldest it will not show the year of the messages, will it? it will start with Older.
There was a problem hiding this comment.
yes, i think older is good enough to fix the issue reported, we dont have to change it, unless someone has a strong opinion. In the ticket itself I proposed year, because i thought thats what we already have.
There was a problem hiding this comment.
also, changing the whole logic of showing years, then months, then week/recent, is more of a feature request, and here im just fixing a bug :)
There was a problem hiding this comment.
IMO it's very strange to start with Older, because it's missing a context of what it's compared to. If anything, it should start with Old. But that's weird.
What is shown in Outlook and others?
There was a problem hiding this comment.
Outlook has it with Years, then Months(Jan..Feb..), than last week, and today. When we worked on the initial feature, Older was proposed for messages older than last month.
I can change the scope of the PR, because yes, its odd to start with Older, but that will need a bit of more work than just fixing the bug reported.
There was a problem hiding this comment.
The feature was always about covering all sorting options. See #11057.
Signed-off-by: greta <gretadoci@gmail.com>
|
Started from scratch here: #11708 |
2 participants
fixes #11567