Skip to content

feat: add html and source editing support #12269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
GretaD wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

feat: add html and source editing support #12269

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6b67ac7
feat: add html and source editing support
GretaD Jan 19, 2026
d4a8743
fixup! feat: add html and source editing support
kesselb Jan 23, 2026
2468695
fixup! feat: add html and source editing support
GretaD Jan 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/components/SignatureSettings.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,9 +271,9 @@ export default {
.warning-large-signature {
color: darkorange;
}

// its a bit hard to make it work without this max-width in the modal because it overlaps with the sidebar of the modal
:deep(.ck.ck-toolbar-dropdown>.ck-dropdown__panel) {
max-width: 34vw;
max-width: 19vw;
}

</style>
29 changes: 26 additions & 3 deletions src/components/TextEditor.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
Base64UploadAdapter,
BlockQuote,
Bold,
DecoupledEditor,
ClassicEditor,
DropdownView,
Essentials,
FindAndReplace,
Expand All @@ -46,6 +46,7 @@
Mention,
Paragraph,
RemoveFormat,
SourceEditing,
Strikethrough,
Subscript,
Superscript,
Expand Down Expand Up @@ -127,7 +128,7 @@
FindAndReplace,
GeneralHtmlSupport,
]
const toolbar = ['undo', 'redo']
const toolbar = ['sourceEditing', 'undo', 'redo']

if (this.html) {
plugins.push(...[
Expand All @@ -148,6 +149,7 @@
RemoveFormat,
Base64UploadAdapter,
MailPlugin,
SourceEditing,
])
toolbar.unshift(...[
'heading',
Expand Down Expand Up @@ -177,7 +179,7 @@
emojiTribute: null,
textSmiles: [],
ready: false,
editor: DecoupledEditor,
editor: ClassicEditor,
config: {
licenseKey: 'GPL',
placeholder: this.placeholder,
Expand Down Expand Up @@ -207,7 +209,28 @@
itemRenderer: this.customRenderer,
},
],
},

Check failure on line 212 in src/components/TextEditor.vue

View workflow job for this annotation

GitHub Actions / NPM lint 

Enforce new lines between multi-line properties in Vue components
htmlSupport: {
allow: [
'table',
'tbody',
'td',
'tfoot',
'th',
'thead',
'tr',
{
name: 'a',
attributes: true,
classes: true,
styles: true

Check failure on line 226 in src/components/TextEditor.vue

View workflow job for this annotation

GitHub Actions / NPM lint 

Missing trailing comma
},
{
name: 'img',
styles: true,
}

Check failure on line 231 in src/components/TextEditor.vue

View workflow job for this annotation

GitHub Actions / NPM lint 

Missing trailing comma
],
},
},
}
},
Expand Down
Loading