Skip to content

fix: Dont hijack mailto links #12409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kesselb wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −14
Open

fix: Dont hijack mailto links #12409

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/Service/Html.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ public function sanitizeHtmlMailBody(string $mailBody, array $messageParameters,
$html = $config->getDefinition('HTML');
$html->info_attr_transform_post['imagesrc'] = new TransformImageSrc($this->urlGenerator);
$html->info_attr_transform_post['cssbackground'] = new TransformStyleURLs($this->urlGenerator);
$html->info_attr_transform_post['htmllinks'] = new TransformHTMLLinks($this->urlGenerator);
$html->info_attr_transform_post['htmllinks'] = new TransformHTMLLinks();

/** @var HTMLPurifier_URIDefinition $uri */
$uri = $config->getDefinition('URI');
Expand Down
13 changes: 0 additions & 13 deletions lib/Service/HtmlPurify/TransformHTMLLinks.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,19 +13,11 @@
use HTMLPurifier_AttrTransform;
use HTMLPurifier_Config;
use HTMLPurifier_Context;
use OCP\IURLGenerator;

/**
* Adds target="_blank" to all outbound links.
*/
class TransformHTMLLinks extends HTMLPurifier_AttrTransform {
/** @var IURLGenerator */
private $urlGenerator;

public function __construct(IURLGenerator $urlGenerator) {
$this->urlGenerator = $urlGenerator;
}

/**
* @param array $attr
* @param HTMLPurifier_Config $config
Expand All @@ -41,11 +33,6 @@ public function transform($attr, $config, $context) {
$attr['target'] = '_blank';
$attr['rel'] = 'external noopener noreferrer';

// Open mailto: links in Mail
if (stripos($attr['href'], 'mailto:') === 0) {
$attr['href'] = $this->urlGenerator->linkToRoute('mail.page.mailto') . '?to=' . substr($attr['href'], 7);
}

return $attr;
}
}
Loading