refactor(dashboard_app): Remove background of widget item icons

Signed-off-by: provokateurin <kate@provokateurin.de>
nextcloud · Aug 30, 2024 · 812aea3 · 812aea3
1 parent 0be6b59
commit 812aea3
Show file tree

Hide file tree

Showing 9 changed files with 16 additions and 16 deletions.
diff --git a/packages/neon_framework/packages/dashboard_app/lib/src/widgets/widget_item.dart b/packages/neon_framework/packages/dashboard_app/lib/src/widgets/widget_item.dart
@@ -24,8 +24,8 @@ class DashboardWidgetItem extends StatelessWidget {
   Widget build(BuildContext context) {
     Widget leading = SizedBox.square(
       dimension: largeIconSize,
-      child: NeonImageWrapper(
-        borderRadius: roundIcon ? BorderRadius.circular(largeIconSize) : null,
+      child: ClipRRect(
+        borderRadius: roundIcon ? BorderRadius.circular(largeIconSize) : BorderRadius.zero,
         child: item.iconUrl.isNotEmpty
             ? NeonUriImage(
                 uri: Uri.parse(item.iconUrl),

diff --git a/packages/neon_framework/packages/dashboard_app/test/goldens/widget.png b/packages/neon_framework/packages/dashboard_app/test/goldens/widget.png
diff --git a/packages/neon_framework/packages/dashboard_app/test/goldens/widget_item.png b/packages/neon_framework/packages/dashboard_app/test/goldens/widget_item.png
diff --git a/...es/neon_framework/packages/dashboard_app/test/goldens/widget_item_not_round.png b/...es/neon_framework/packages/dashboard_app/test/goldens/widget_item_not_round.png
diff --git a/packages/neon_framework/packages/dashboard_app/test/goldens/widget_not_round.png b/packages/neon_framework/packages/dashboard_app/test/goldens/widget_not_round.png
diff --git a/packages/neon_framework/packages/dashboard_app/test/goldens/widget_with_empty.png b/packages/neon_framework/packages/dashboard_app/test/goldens/widget_with_empty.png
diff --git a/...mework/packages/dashboard_app/test/goldens/widget_with_empty_and_half_empty.png b/...mework/packages/dashboard_app/test/goldens/widget_with_empty_and_half_empty.png
diff --git a/...s/neon_framework/packages/dashboard_app/test/goldens/widget_with_half_empty.png b/...s/neon_framework/packages/dashboard_app/test/goldens/widget_with_half_empty.png
diff --git a/packages/neon_framework/packages/dashboard_app/test/widget_test.dart b/packages/neon_framework/packages/dashboard_app/test/widget_test.dart
@@ -70,10 +70,10 @@ void main() {
           isNotNull,
         ),
       );
-      expect(find.byType(NeonImageWrapper), findsOneWidget);
+      expect(find.byType(ClipRRect), findsOneWidget);
       expect(
-        tester.widget(find.byType(NeonImageWrapper)),
-        isA<NeonImageWrapper>().having(
+        tester.widget(find.byType(ClipRRect)),
+        isA<ClipRRect>().having(
           (a) => a.borderRadius,
           'borderRadius is correct',
           BorderRadius.circular(largeIconSize),
@@ -98,11 +98,11 @@ void main() {
       );
 
       expect(
-        tester.widget(find.byType(NeonImageWrapper)),
-        isA<NeonImageWrapper>().having(
+        tester.widget(find.byType(ClipRRect)),
+        isA<ClipRRect>().having(
           (a) => a.borderRadius,
-          'borderRadius is null',
-          null,
+          'borderRadius is zero',
+          BorderRadius.zero,
         ),
       );
 
@@ -301,10 +301,10 @@ void main() {
           isNotNull,
         ),
       );
-      expect(find.byType(NeonImageWrapper), findsOneWidget);
+      expect(find.byType(ClipRRect), findsOneWidget);
       expect(
-        tester.widget(find.byType(NeonImageWrapper)),
-        isA<NeonImageWrapper>().having(
+        tester.widget(find.byType(ClipRRect)),
+        isA<ClipRRect>().having(
           (a) => a.borderRadius,
           'borderRadius is correct',
           BorderRadius.circular(largeIconSize),
@@ -364,11 +364,11 @@ void main() {
       );
 
       expect(
-        tester.widget(find.byType(NeonImageWrapper)),
-        isA<NeonImageWrapper>().having(
+        tester.widget(find.byType(ClipRRect)),
+        isA<ClipRRect>().having(
           (a) => a.borderRadius,
-          'borderRadius is null',
-          null,
+          'borderRadius is zero',
+          BorderRadius.zero,
         ),
       );