feat(dynamite_runtime,nextcloud): add addAll method to HttpHeaders

Signed-off-by: Nikolas Rimikis <leptopoda@users.noreply.github.com>
nextcloud · Nov 19, 2023 · 8a5ea4f · 8a5ea4f
1 parent c5f54ea
commit 8a5ea4f
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 7 deletions.
diff --git a/packages/dynamite/dynamite_runtime/lib/src/dynamite_client.dart b/packages/dynamite/dynamite_runtime/lib/src/dynamite_client.dart
@@ -442,9 +442,8 @@ class DynamiteClient {
     final Set<int>? validStatuses,
   ) async {
     final request = await httpClient.openUrl(method, uri);
-    for (final header in headers.entries) {
-      request.headers.add(header.key, header.value);
-    }
+    request.headers.addAll(headers);
+
     if (body != null) {
       request.add(body);
     }

diff --git a/packages/dynamite/dynamite_runtime/lib/src/http_extensions.dart b/packages/dynamite/dynamite_runtime/lib/src/http_extensions.dart
@@ -41,3 +41,13 @@ extension HttpClientResponseExtension on HttpClientResponse {
     return responseHeaders;
   }
 }
+
+/// Extension for http headers.
+extension HttpHeadersExtension on HttpHeaders {
+  /// Iteratively adds all header values.
+  void addAll(final Map<String, String> headers) {
+    for (final header in headers.entries) {
+      add(header.key, header.value);
+    }
+  }
+}
diff --git a/packages/nextcloud/lib/src/webdav/client.dart b/packages/nextcloud/lib/src/webdav/client.dart
@@ -32,14 +32,13 @@ class WebDavClient {
 
     final request = await rootClient.httpClient.openUrl(method, url)
       ..persistentConnection = true;
-    for (final header in {
+
+    request.headers.addAll({
       HttpHeaders.contentTypeHeader: 'application/xml',
       ...?rootClient.baseHeaders,
       ...?headers,
       ...?rootClient.authentications.firstOrNull?.headers,
-    }.entries) {
-      request.headers.add(header.key, header.value);
-    }
+    });
 
     if (data != null) {
       request.add(data);