Merge pull request #978 from nextcloud/refactor/neon_lints

Refactor/neon lints
nextcloud · Oct 16, 2023 · d060f7d · d060f7d
2 parents cf13862 + 2a7ec85
commit d060f7d
Show file tree

Hide file tree

Showing 9 changed files with 21 additions and 8 deletions.
diff --git a/packages/app/lib/apps.dart b/packages/app/lib/apps.dart
@@ -4,6 +4,7 @@ import 'package:neon_news/neon_news.dart';
 import 'package:neon_notes/neon_notes.dart';
 import 'package:neon_notifications/neon_notifications.dart';
 
+/// The collection of clients enabled for the Neon app.
 final Set<AppImplementation> appImplementations = {
   FilesApp(),
   NewsApp(),

diff --git a/packages/app/lib/branding.dart b/packages/app/lib/branding.dart
@@ -3,11 +3,13 @@ import 'dart:ui';
 import 'package:neon/theme.dart';
 import 'package:vector_graphics/vector_graphics.dart';
 
+/// The custom theme used in the Neon app.
 const neonTheme = NeonTheme(
   branding: branding,
   colorScheme: colorScheme,
 );
 
+/// The custom branding used in the Neon app.
 const branding = Branding(
   name: 'Nextcloud Neon',
   logo: VectorGraphic(
@@ -22,6 +24,7 @@ const branding = Branding(
   legalese: 'Copyright © 2023, provokateurin\nUnder GPLv3 license',
 );
 
+/// The custom color scheme used in the Neon app.
 const colorScheme = NeonColorScheme(
   primary: Color(0xFFF37736),
 );
diff --git a/packages/neon/neon/analysis_options.yaml b/packages/neon/neon/analysis_options.yaml
@@ -1,4 +1,4 @@
-include: package:neon_lints/flutter_package.yaml
+include: package:neon_lints/flutter.yaml
 
 linter:
   rules:

diff --git a/packages/neon/neon_files/analysis_options.yaml b/packages/neon/neon_files/analysis_options.yaml
@@ -1,5 +1,9 @@
 include: package:neon_lints/flutter.yaml
 
+linter:
+  rules:
+    public_member_api_docs: false
+
 analyzer:
   exclude:
     - lib/l10n/**
diff --git a/packages/neon/neon_news/analysis_options.yaml b/packages/neon/neon_news/analysis_options.yaml
@@ -1,5 +1,9 @@
 include: package:neon_lints/flutter.yaml
 
+linter:
+  rules:
+    public_member_api_docs: false
+
 analyzer:
   exclude:
     - lib/l10n/**
diff --git a/packages/neon/neon_notes/analysis_options.yaml b/packages/neon/neon_notes/analysis_options.yaml
@@ -1,5 +1,9 @@
 include: package:neon_lints/flutter.yaml
 
+linter:
+  rules:
+    public_member_api_docs: false
+
 analyzer:
   exclude:
     - lib/l10n/**
diff --git a/packages/neon/neon_notifications/analysis_options.yaml b/packages/neon/neon_notifications/analysis_options.yaml
@@ -1,5 +1,9 @@
 include: package:neon_lints/flutter.yaml
 
+linter:
+  rules:
+    public_member_api_docs: false
+
 analyzer:
   exclude:
     - lib/l10n/**
diff --git a/packages/neon_lints/lib/flutter.yaml b/packages/neon_lints/lib/flutter.yaml
@@ -2,6 +2,4 @@ include: package:neon_lints/src/base.yaml
 
 linter:
   rules:
-    public_member_api_docs: false
-    library_private_types_in_public_api: false
     avoid_print: true
diff --git a/packages/neon_lints/lib/flutter_package.yaml b/packages/neon_lints/lib/flutter_package.yaml