perf(neon): do not use the spread operator for building lists #1094
Conversation
Signed-off-by: Nikolas Rimikis <leptopoda@users.noreply.github.com>
Signed-off-by: Nikolas Rimikis <leptopoda@users.noreply.github.com>
|
Draft is on purpose? |
|
This time yes. |
Signed-off-by: Nikolas Rimikis <leptopoda@users.noreply.github.com>
Signed-off-by: Nikolas Rimikis <leptopoda@users.noreply.github.com>
… lists Signed-off-by: Nikolas Rimikis <leptopoda@users.noreply.github.com>
Leptopoda
force-pushed
the
performance/neon/change_spread_operator
branch
from
42d074c to
22ac4ed
Compare
|
Oh totally forgot to mark it as ready for review 🤦♀️ |
| if (branding.showLoginWithNextcloud) | ||
| Padding( | ||
| padding: const EdgeInsets.only(top: 10), | ||
| child: Text(NeonLocalizations.of(context).loginWorksWith), | ||
| ), | ||
| Text(NeonLocalizations.of(context).loginWorksWith), | ||
| const SizedBox( | ||
| height: 10, | ||
| ), | ||
| Semantics( | ||
| label: NeonLocalizations.of(context).nextcloud, | ||
| child: const NextcloudLogo(), | ||
| if (branding.showLoginWithNextcloud) |
There was a problem hiding this comment.
Duplicate condition, better use a generator function for the whole thing
There was a problem hiding this comment.
Duplicate condition -> generator function
There was a problem hiding this comment.
Duplicate condition -> generator function
There was a problem hiding this comment.
Duplicate condition -> generator function
There was a problem hiding this comment.
Duplicate condition -> generator function
|
Thanks for the feedback. |
|
Btw please check everything again after rebasing. We mostly touched the dynamite and nextcloud packages in the last few weeks, but maybe there are some new occurrences. |
|
Closing this one. |
Fixes: #696