Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(neon): Fix UnifiedPush distributors not showing up in settings #1117

Merged
merged 1 commit into from
Nov 6, 2023
Merged

fix(neon): Fix UnifiedPush distributors not showing up in settings #1117

merged 1 commit into from
Nov 6, 2023

Conversation

provokateurin
Copy link
Member

Fixes #1115

@provokateurin
fix(neon): Fix UnifiedPush distributors not showing up in settings
652f415 
Signed-off-by: jld3103 <jld3103yt@gmail.com>
Leptopoda
Leptopoda approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@Leptopoda Leptopoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine
Can we unit test this? Looking at the imports of the file it doesn't rely on any of our blocs so it should be relatively easy.

@provokateurin
Copy link
Member Author

Good idea, especially with the changes coming with #1079. I'll do a follow up to land the fix now.

@provokateurin provokateurin merged commit c127cab into main Nov 6, 2023
9 checks passed
@provokateurin provokateurin deleted the fix/neon/unifiedpush-distributors-settings branch November 6, 2023 08:22
@provokateurin provokateurin mentioned this pull request Nov 6, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Leptopoda Leptopoda Leptopoda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UnifiedPush distributors not being detected
2 participants
@provokateurin @Leptopoda