refactor(nextcloud): Rework version checks #1157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
provokateurin
commented
Nov 18, 2023
Leptopoda
requested changes
Nov 18, 2023
provokateurin
force-pushed
the
refactor/nextcloud/version-check
branch
from
c0143b3 to
e1d4720
Compare
provokateurin
force-pushed
the
refactor/nextcloud/version-check
branch
from
e1d4720 to
8e3ea75
Compare
|
@Leptopoda please review again |
Leptopoda
reviewed
Nov 19, 2023
Signed-off-by: jld3103 <jld3103yt@gmail.com>
… maximum version Signed-off-by: jld3103 <jld3103yt@gmail.com>
provokateurin
force-pushed
the
refactor/nextcloud/version-check
branch
from
8e3ea75 to
3c74993
Compare
Leptopoda
approved these changes
Nov 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #571
Allows to define proper minimum and maximum versions.