Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(neon_framework): introduce storage library #1554

Merged
merged 11 commits into from
Feb 1, 2024

Conversation

Leptopoda
Copy link
Member

first cleanup step towards #1538

@provokateurin provokateurin force-pushed the feat/neon_framework/request-manager-header-caching branch 3 times, most recently from c66340b to 88a1713 Compare January 30, 2024 15:36
Base automatically changed from feat/neon_framework/request-manager-header-caching to main January 30, 2024 17:07
@Leptopoda Leptopoda force-pushed the refactor/neon_framework/storages branch from 97da2cf to 807e287 Compare January 30, 2024 17:18
Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like that often the class and file names don't match (not only the ones I mentioned).

Other than that it LGTM and definitely is a nice cleanup!

@Leptopoda Leptopoda force-pushed the refactor/neon_framework/storages branch from 807e287 to 90982af Compare January 31, 2024 18:21
@Leptopoda
Copy link
Member Author

I already had these changes locally.
I put it into a separate commit to keep the history sorta readable.

@Leptopoda Leptopoda force-pushed the refactor/neon_framework/storages branch from 90982af to 150b962 Compare January 31, 2024 19:08
… storage need for Neon

Signed-off-by: Nikolas Rimikis <leptopoda@users.noreply.github.com>
Signed-off-by: Nikolas Rimikis <leptopoda@users.noreply.github.com>
Signed-off-by: Nikolas Rimikis <leptopoda@users.noreply.github.com>
Signed-off-by: Nikolas Rimikis <leptopoda@users.noreply.github.com>
…its interface

Signed-off-by: Nikolas Rimikis <leptopoda@users.noreply.github.com>
Signed-off-by: Nikolas Rimikis <leptopoda@users.noreply.github.com>
Signed-off-by: Nikolas Rimikis <leptopoda@users.noreply.github.com>
Signed-off-by: Nikolas Rimikis <leptopoda@users.noreply.github.com>
Signed-off-by: Nikolas Rimikis <leptopoda@users.noreply.github.com>
… of the storage backends

Signed-off-by: Nikolas Rimikis <leptopoda@users.noreply.github.com>
Signed-off-by: Nikolas Rimikis <leptopoda@users.noreply.github.com>
@Leptopoda Leptopoda force-pushed the refactor/neon_framework/storages branch from 150b962 to c5c04ce Compare February 1, 2024 10:48
@Leptopoda Leptopoda enabled auto-merge February 1, 2024 10:50
@Leptopoda Leptopoda merged commit 7a722d2 into main Feb 1, 2024
8 checks passed
@Leptopoda Leptopoda deleted the refactor/neon_framework/storages branch February 1, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants