Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(neon_dashboard): Cache widgets and items #1570

Merged
merged 3 commits into from
Feb 9, 2024
Merged

refactor(neon_dashboard): Cache widgets and items #1570

merged 3 commits into from
Feb 9, 2024

Conversation

provokateurin
Copy link
Member

@provokateurin provokateurin commented Feb 2, 2024 •
edited
Loading

TODO:

  • Write tests for the whole bloc

@provokateurin provokateurin marked this pull request as draft February 2, 2024 09:24
Leptopoda
Leptopoda reviewed Feb 4, 2024
View reviewed changes
Copy link
Member

@Leptopoda Leptopoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor nitpicks

@provokateurin provokateurin force-pushed the refactor/neon_dashboard/cache-widgets-items branch from 8ad3a77 to 6194cef Compare February 6, 2024 08:28
@provokateurin
Copy link
Member Author

I applied your suggestions, but the tests are still missing.

@provokateurin provokateurin force-pushed the refactor/neon_dashboard/cache-widgets-items branch from 6194cef to 6f56806 Compare February 6, 2024 10:42
@provokateurin
refactor(neon_framework): Pass all query parameters in Bloc tests
3a6c0b9 
Signed-off-by: provokateurin <kate@provokateurin.de>
@provokateurin
refactor(neon_dashboard): Cache widgets and items
fba6934 
Signed-off-by: provokateurin <kate@provokateurin.de>
@provokateurin provokateurin force-pushed the refactor/neon_dashboard/cache-widgets-items branch from 6f56806 to c148d4e Compare February 8, 2024 22:24
@provokateurin provokateurin marked this pull request as ready for review February 8, 2024 22:25
@provokateurin
Copy link
Member Author

@Leptopoda tests are done, ready to be reviewed

@provokateurin
test(neon_dashboard): Add tests for the DashboardBloc
5ec2b50 
Signed-off-by: provokateurin <kate@provokateurin.de>
@provokateurin provokateurin force-pushed the refactor/neon_dashboard/cache-widgets-items branch from c148d4e to 5ec2b50 Compare February 8, 2024 22:31
@provokateurin provokateurin merged commit efa25f6 into main Feb 9, 2024
8 checks passed
@provokateurin provokateurin deleted the refactor/neon_dashboard/cache-widgets-items branch February 9, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Leptopoda Leptopoda Leptopoda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@provokateurin @Leptopoda