refactor: Remove unnecessary generic type arguments #1599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
provokateurin
force-pushed
the
refactor/remove-unnecessary-generics
branch
2 times, most recently
from
d4bc670 to
33ba9fa
Compare
Leptopoda
reviewed
Feb 13, 2024
provokateurin
force-pushed
the
refactor/neon_framework/make-appimplementations-set
branch
from
200c8c2 to
a70b125
Compare
Base automatically changed from
refactor/neon_framework/make-appimplementations-set
to
main
February 14, 2024 07:31
provokateurin
force-pushed
the
refactor/remove-unnecessary-generics
branch
from
33ba9fa to
a9fda7b
Compare
Signed-off-by: provokateurin <kate@provokateurin.de>
provokateurin
force-pushed
the
refactor/remove-unnecessary-generics
branch
from
a9fda7b to
bab0ed2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Much cleaner code by omitting all the unnecessary generic type arguments.
In the Blocs I found a bunch of places where the subjects were not final, I fixed that too (I could extract it if really necessary).
I used the following regex to find all the potential places:
[A-Z]+[A-Za-z]*<.*>(\(|\.)(notice the leading space; this also finds a bunch of false-positives and in a few places the generics are still needed).