feat(neon_framework): Add ResultListBuilder widget #1623
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
provokateurin
force-pushed
the
feat/neon_framework/result-list-builder
branch
from
2983473 to
9ed1b41
Compare
provokateurin
force-pushed
the
refactor/neon_framework/unified-search-decouple-nested-data
branch
from
3712bf5 to
e251b14
Compare
Base automatically changed from
refactor/neon_framework/unified-search-decouple-nested-data
to
main
February 22, 2024 12:25
provokateurin
force-pushed
the
feat/neon_framework/result-list-builder
branch
2 times, most recently
from
545454e to
5ce8791
Compare
|
@Leptopoda can you review the implementation? I haven't yet found a solution to the problem with the "stuck" images. |
provokateurin
force-pushed
the
feat/neon_framework/result-list-builder
branch
from
5ce8791 to
6569693
Compare
Leptopoda
reviewed
Feb 24, 2024
provokateurin
force-pushed
the
feat/neon_framework/result-list-builder
branch
3 times, most recently
from
f221894 to
ffcc778
Compare
Signed-off-by: provokateurin <kate@provokateurin.de>
Signed-off-by: provokateurin <kate@provokateurin.de>
Signed-off-by: provokateurin <kate@provokateurin.de>
provokateurin
force-pushed
the
feat/neon_framework/result-list-builder
branch
from
ffcc778 to
cc593f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #890
This reduces a lot of flickering because the data, error and loading states updates are rendered separately.
If the data is updated it will still cause images to reload as they are not optimized yet.
While submitting this PR I realized that now the images (only seems to affect Image.memory) stay incorrectly if an image in between is removed. I remember we already had this problem at some point, but I forgot what the fix was. I will try to dig up the fix...