-
Notifications
You must be signed in to change notification settings - Fork 34
feat(neon_framework): use adaptive icons #1629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we make a script that prevents us using Icons.
and MdiIcons.
directly? I'm sure we and others will forget it otherwise
I also thought about it but it might be more complex.
I think there would be a lot of false positives |
Ok, but then we have to be careful when adding new icons anywhere. |
For now missing one should not be an issue as we don't yet take the iOS design seriously. |
e1b38f5
to
7961c40
Compare
7961c40
to
d121c81
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but what about neon_talk?
Just forgot it. |
Some additional icons won't hurt much and it will make it much easier for developers, so I'd say we should put the icons into the framework whenever possible. |
d121c81
to
753cf53
Compare
Signed-off-by: Nikolas Rimikis <leptopoda@users.noreply.github.com>
753cf53
to
8b8e1c4
Compare
Just a small step towards a proper iOS design.
There are places where this change looks really good (e.g. the files app) and other ones where it currently looks a bit out of place (the notes bottom nav bar now is material design with cupertino icons).
I hope we can still land it :)