Skip to content

feat(neon_framework): use adaptive icons #1629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

Leptopoda
Copy link
Member

Just a small step towards a proper iOS design.
There are places where this change looks really good (e.g. the files app) and other ones where it currently looks a bit out of place (the notes bottom nav bar now is material design with cupertino icons).
I hope we can still land it :)

Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we make a script that prevents us using Icons. and MdiIcons. directly? I'm sure we and others will forget it otherwise

@Leptopoda
Copy link
Member Author

I also thought about it but it might be more complex.

  1. what about MdiIcons?
  2. some icons do not have an apple equivalent (double checkmark to clear all notifications)
  3. some icons are only ever shown on material platforms (the file picker dialog on iOS does not show the camera, folder and other icons). In general iOS dialogs do not use icons.

I think there would be a lot of false positives

@provokateurin
Copy link
Member

Ok, but then we have to be careful when adding new icons anywhere.

@Leptopoda
Copy link
Member Author

For now missing one should not be an issue as we don't yet take the iOS design seriously.
But once we support it we also have to be careful with the entire UI (thinking of #1626).

@Leptopoda Leptopoda force-pushed the feat/neon_framework/custom_adaptive_icons branch 2 times, most recently from e1b38f5 to 7961c40 Compare February 21, 2024 12:54
@Leptopoda Leptopoda force-pushed the feat/neon_framework/custom_adaptive_icons branch from 7961c40 to d121c81 Compare February 29, 2024 12:35
Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but what about neon_talk?

@Leptopoda
Copy link
Member Author

Just forgot it.
This is a broader question but should we add all the app specific icons to the framework or just have a few common ones with each app defining their own set (similar to what we do with the dialogs)?

@provokateurin
Copy link
Member

Some additional icons won't hurt much and it will make it much easier for developers, so I'd say we should put the icons into the framework whenever possible.

@Leptopoda Leptopoda force-pushed the feat/neon_framework/custom_adaptive_icons branch from d121c81 to 753cf53 Compare February 29, 2024 13:11
Signed-off-by: Nikolas Rimikis <leptopoda@users.noreply.github.com>
@Leptopoda Leptopoda force-pushed the feat/neon_framework/custom_adaptive_icons branch from 753cf53 to 8b8e1c4 Compare February 29, 2024 13:13
@Leptopoda Leptopoda enabled auto-merge February 29, 2024 13:14
@Leptopoda Leptopoda merged commit 9127ae4 into main Feb 29, 2024
@Leptopoda Leptopoda deleted the feat/neon_framework/custom_adaptive_icons branch February 29, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants