fix(nextcloud): Add missing share types #1647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leptopoda
reviewed
Feb 24, 2024
provokateurin
force-pushed
the
fix/nextcloud/fix-share-type-values
branch
from
243f953 to
7f6f38d
Compare
provokateurin
changed the title
Signed-off-by: provokateurin <kate@provokateurin.de>
provokateurin
force-pushed
the
fix/nextcloud/fix-share-type-values
branch
from
7f6f38d to
f03f75f
Compare
provokateurin
changed the title
Leptopoda
approved these changes
Feb 24, 2024
|
TBH I would just keep it like this and not make any further changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aligned with https://github.com/nextcloud/server/blob/master/lib/public/Share/IShare.php
I had to use the value backed enum because it seems like 14 was just skipped. In the future we might also want to just remove the deprecated values, so this prepares us for that as well.