fix(neon_framework): User status DND takes precedence over emoji #1664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shouldn't be that hard to add unit tests or am I mistaken? |
|
Yeah, but it will require adding tests for the whole widget which I didn't have the time for yet. |
provokateurin
force-pushed
the
fix/neon_framework/user-status-dnd-over-emoji
branch
from
edd24bf to
626d25b
Compare
|
@Leptopoda I added tests (and split up the logic so it is easier to test). |
provokateurin
force-pushed
the
fix/neon_framework/user-status-dnd-over-emoji
branch
from
626d25b to
a4f83c1
Compare
Signed-off-by: provokateurin <kate@provokateurin.de>
provokateurin
force-pushed
the
fix/neon_framework/user-status-dnd-over-emoji
branch
2 times, most recently
from
258cb11 to
8754189
Compare
Leptopoda
approved these changes
Feb 28, 2024
provokateurin
deleted the
fix/neon_framework/user-status-dnd-over-emoji
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.