Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(neon_framework): add account column to RequestCache #1741

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

Leptopoda
Copy link
Member

Signed-off-by: Nikolas Rimikis leptopoda@users.noreply.github.com

@Leptopoda Leptopoda enabled auto-merge March 10, 2024 18:15
@Leptopoda Leptopoda changed the title refactor(neon_framework): adjust request cache schema refactor(neon_framework): add account column to RequestCache Mar 10, 2024
@Leptopoda Leptopoda force-pushed the refactor/neon_framework/adjust_request_cache_schema branch from 6712144 to 12d0de0 Compare March 10, 2024 21:04
@Leptopoda Leptopoda requested a review from provokateurin March 10, 2024 21:04
@Leptopoda Leptopoda force-pushed the refactor/neon_framework/adjust_request_cache_schema branch from 12d0de0 to 9a021bd Compare March 15, 2024 12:27
@Leptopoda Leptopoda requested a review from provokateurin March 15, 2024 12:27
@Leptopoda Leptopoda disabled auto-merge March 15, 2024 12:27
Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/neon_framework/lib/src/storage/request_cache.dart Outdated Show resolved Hide resolved
@Leptopoda Leptopoda force-pushed the refactor/neon_framework/adjust_request_cache_schema branch from 9a021bd to 742837b Compare March 15, 2024 13:03
@Leptopoda Leptopoda requested a review from provokateurin March 15, 2024 13:03
Copy link

codecov bot commented Mar 15, 2024

Codecov Report

Attention: Patch coverage is 80.95238% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 42.67%. Comparing base (df103aa) to head (8f0ece3).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1741      +/-   ##
==========================================
+ Coverage   42.45%   42.67%   +0.21%     
==========================================
  Files         112      112              
  Lines        3660     3672      +12     
==========================================
+ Hits         1554     1567      +13     
+ Misses       2106     2105       -1     
Files Coverage Δ
.../neon_framework/lib/src/utils/request_manager.dart 66.97% <100.00%> (+1.92%) ⬆️
.../neon_framework/lib/src/storage/request_cache.dart 62.90% <75.00%> (+5.76%) ⬆️

... and 2 files with indirect coverage changes

Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So now you also changed it back to milliseconds again? Was that intentional?

packages/neon_framework/lib/src/storage/request_cache.dart Outdated Show resolved Hide resolved
@Leptopoda
Copy link
Member Author

Yep that was intentional.
I'll put it in a separate PR

Signed-off-by: Nikolas Rimikis <leptopoda@users.noreply.github.com>
@Leptopoda Leptopoda force-pushed the refactor/neon_framework/adjust_request_cache_schema branch from 742837b to 8f0ece3 Compare March 15, 2024 15:52
@Leptopoda Leptopoda merged commit 0bee00f into main Mar 15, 2024
10 checks passed
@Leptopoda Leptopoda deleted the refactor/neon_framework/adjust_request_cache_schema branch March 15, 2024 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants