feat(nextcloud): add custom http date parser to support rfc822 time zone offsets #1763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leptopoda
changed the title
Leptopoda
force-pushed
the
refactor/use_timezone_datetime
branch
from
8df34ea to
c320200
Compare
Leptopoda
force-pushed
the
fix/neon_framework/http_date_parsing
branch
from
b33219c to
b4610a6
Compare
provokateurin
approved these changes
Mar 13, 2024
Leptopoda
force-pushed
the
fix/neon_framework/http_date_parsing
branch
2 times, most recently
from
d884d98 to
617b446
Compare
|
Btw shouldn't the commit scope be the nextcloud package? |
…one offsets Signed-off-by: Nikolas Rimikis <leptopoda@users.noreply.github.com>
Leptopoda
force-pushed
the
fix/neon_framework/http_date_parsing
branch
from
617b446 to
6ab8f5d
Compare
Leptopoda
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nikolas Rimikis leptopoda@users.noreply.github.com
Fixes the issue of parsing an RFC822 date with a timezone offset.
The code is pulled in from the upstream http_parser package and adjusted to also handle our use case.
I disabled failing lint rules instead of fixing them to keep the code similar to upstream.
As a bonus I also converted the code to directly use a tz.TZDateTime so we can avoid parsing it later on.