-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tool,nextcloud)!: Generate rich object parameters #1877
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1877 +/- ##
==========================================
+ Coverage 30.85% 30.92% +0.07%
==========================================
Files 262 265 +3
Lines 96602 96709 +107
==========================================
+ Hits 29808 29911 +103
- Misses 66794 66798 +4
*This pull request uses carry forward flags. Click here to find out more.
|
4c998dc
to
791d794
Compare
791d794
to
66e488e
Compare
I change the patch to only be a simple object instead of the discriminator so in theory it is usable now (and also everything works). I would like to first upstream the missing parameter type and missing fields. Additionally we have to wait until the next Talk releases which will include nextcloud/spreed#12021 as the some parameters were incorrectly not typed as string before. |
Ok apparently the fix for Talk was only backport to 29. To keep supporting the broken values we'll have to change the type to |
66e488e
to
2406cda
Compare
PR for the fields that are missing in the current definitions is sent upstream: nextcloud/server#45424 |
2406cda
to
be34dde
Compare
be34dde
to
dd180e0
Compare
Let's just get this merged and using the discriminator can be done later once dynamite properly supports it again. |
fe63baf
to
aa0fd2a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please verify the comment.
…tches Signed-off-by: provokateurin <kate@provokateurin.de>
Signed-off-by: provokateurin <kate@provokateurin.de>
aa0fd2a
to
c624c39
Compare
Closes #1847
Not really useful at the moment because of the lack of discriminator support (#1231) and a way to use exhaustive switch statements.