Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(neon_talk): Update parent messages #2189

Merged
merged 3 commits into from
Jul 9, 2024

Conversation

provokateurin
Copy link
Member

Fixes #2178
Depends on #2179

@provokateurin provokateurin requested a review from Leptopoda June 21, 2024 05:51
@provokateurin provokateurin force-pushed the feat/neon_talk/delete-message branch 2 times, most recently from aeb9814 to 1ec45aa Compare June 24, 2024 07:55
@provokateurin provokateurin marked this pull request as ready for review June 24, 2024 07:56
Base automatically changed from feat/neon_talk/delete-message to fix/neon_talk/respect-read-only-permissions July 1, 2024 20:08
An error occurred while trying to automatically change base from feat/neon_talk/delete-message to fix/neon_talk/respect-read-only-permissions July 1, 2024 20:08
Base automatically changed from fix/neon_talk/respect-read-only-permissions to main July 9, 2024 07:32
Signed-off-by: provokateurin <kate@provokateurin.de>
@provokateurin provokateurin force-pushed the fix/neon_talk/update-parent-messages branch from 285bfd0 to 9cbae4a Compare July 9, 2024 09:17
@provokateurin
Copy link
Member Author

I messed up when merging #2173, so I'm fixing that here as well.

@provokateurin provokateurin enabled auto-merge July 9, 2024 09:18
Signed-off-by: provokateurin <kate@provokateurin.de>
Signed-off-by: provokateurin <kate@provokateurin.de>
@provokateurin provokateurin force-pushed the fix/neon_talk/update-parent-messages branch from 9cbae4a to 25d007d Compare July 9, 2024 09:37
Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.68%. Comparing base (5b30e96) to head (25d007d).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2189      +/-   ##
==========================================
- Coverage   29.71%   29.68%   -0.04%     
==========================================
  Files         260      259       -1     
  Lines       95220    94757     -463     
==========================================
- Hits        28295    28124     -171     
+ Misses      66925    66633     -292     
Flag Coverage Δ *Carryforward flag
cookie_store 90.51% <ø> (ø) Carriedforward from acad4fa
dynamite 31.10% <ø> (+0.01%) ⬆️ Carriedforward from acad4fa
dynamite_end_to_end_test 60.03% <ø> (-0.93%) ⬇️ Carriedforward from acad4fa
dynamite_runtime 85.40% <ø> (ø) Carriedforward from acad4fa
neon_dashboard 96.20% <ø> (ø)
neon_framework 44.70% <ø> (ø)
neon_notifications 100.00% <ø> (ø)
neon_talk 98.94% <100.00%> (+0.14%) ⬆️
nextcloud 26.28% <ø> (+0.16%) ⬆️
sort_box 90.90% <ø> (ø) Carriedforward from acad4fa

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
packages/neon/neon_talk/lib/src/blocs/room.dart 98.50% <100.00%> (+0.62%) ⬆️

... and 8 files with indirect coverage changes

@provokateurin provokateurin merged commit ba1555c into main Jul 9, 2024
9 of 10 checks passed
@provokateurin provokateurin deleted the fix/neon_talk/update-parent-messages branch July 9, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Also update parents of chat messages
2 participants