fix(dynamite_runtime): use content type header to deserialize response #2228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packages/dynamite/dynamite_runtime/lib/src/client/response.dart
Outdated
Show resolved
Hide resolved
packages/dynamite/dynamite_runtime/lib/src/client/response.dart
Outdated
Show resolved
Hide resolved
Leptopoda
force-pushed
the
fix/dynamite_runtime/media_type_parsing
branch
from
6843e3a to
f78138f
Compare
Leptopoda
changed the base branch from
main
to
fix/nextcloud/notes_api_delte_returns_array
|
With #2249 this should pass now (once the CI is a live again) |
packages/dynamite/dynamite_runtime/lib/src/client/response.dart
Outdated
Show resolved
Hide resolved
Leptopoda
force-pushed
the
fix/dynamite_runtime/media_type_parsing
branch
from
f78138f to
995753e
Compare
provokateurin
approved these changes
Jul 8, 2024
Base automatically changed from
fix/nextcloud/notes_api_delte_returns_array
to
main
July 8, 2024 14:55
Signed-off-by: Nikolas Rimikis <leptopoda@users.noreply.github.com>
Leptopoda
force-pushed
the
fix/dynamite_runtime/media_type_parsing
branch
from
995753e to
f8e7232
Compare
Signed-off-by: Nikolas Rimikis <leptopoda@users.noreply.github.com>
Signed-off-by: Nikolas Rimikis <leptopoda@users.noreply.github.com>
Signed-off-by: Nikolas Rimikis <leptopoda@users.noreply.github.com>
Signed-off-by: Nikolas Rimikis <leptopoda@users.noreply.github.com>
Signed-off-by: Nikolas Rimikis <leptopoda@users.noreply.github.com>
Leptopoda
force-pushed
the
fix/dynamite_runtime/media_type_parsing
branch
from
f8e7232 to
5b30e96
Compare
|
I had to adjust most bloc tests as they rely on both |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2228 +/- ##
=======================================
Coverage 29.71% 29.71%
=======================================
Files 260 260
Lines 95220 95220
=======================================
Hits 28295 28295
Misses 66925 66925
*This pull request uses carry forward flags. Click here to find out more. |
provokateurin
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding back the http_parser dependency :)