refactor(neon_news, neon_notes, neon_notifications): replace long press actions with swipe-to-dismiss #2241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
provokateurin
requested changes
Jul 4, 2024
|
Thanks for the work btw :) |
most welcome , will be updating the changes soon, and btw you are literally very active , thanks for the feedback and guidance :) |
provokateurin
approved these changes
Jul 4, 2024
satvik2131
changed the title
satvik2131
force-pushed
the
main
branch
2 times, most recently
from
d0ad239 to
e2422d2
Compare
|
You only changed the PR title, not the commit message. Also please don't mention the issue, you can just put it in the PR description to refer to the issue. |
satvik2131
changed the title
satvik2131
force-pushed
the
main
branch
2 times, most recently
from
665a48c to
0b1abf9
Compare
|
Please checkout the issues the CI found. You can run |
auto-merge was automatically disabled
July 5, 2024 03:05
Head branch was pushed to by a user without write access
satvik2131
force-pushed
the
main
branch
2 times, most recently
from
d8e20c1 to
5b32b71
Compare
provokateurin
requested changes
Jul 5, 2024
packages/neon/neon_notifications/lib/src/widgets/notification.dart
Outdated
Show resolved
Hide resolved
… actions with swipe-to-dismiss Signed-off-by: satvik2131 <satvik213161@gmail.com> Signed-off-by: provokateurin <kate@provokateurin.de>
provokateurin
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2158
Implemented swipe-to-dismiss feature in :
Neon News
Neon Notifications
Neon notes