Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(neon_framework): Fix QR-Code login routes #2259

Merged
merged 1 commit into from
Jul 13, 2024

Conversation

provokateurin
Copy link
Member

Fixes #1706

Signed-off-by: provokateurin <kate@provokateurin.de>
@provokateurin provokateurin requested a review from Leptopoda July 12, 2024 16:32
Copy link

codecov bot commented Jul 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 35 lines in your changes missing coverage. Please review.

Project coverage is 29.67%. Comparing base (9185cd2) to head (96d35d4).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2259      +/-   ##
==========================================
- Coverage   29.68%   29.67%   -0.01%     
==========================================
  Files         259      259              
  Lines       94757    94765       +8     
==========================================
  Hits        28124    28124              
- Misses      66633    66641       +8     
Flag Coverage Δ *Carryforward flag
cookie_store 90.51% <ø> (ø) Carriedforward from 8552b83
dynamite 31.10% <ø> (ø) Carriedforward from 8552b83
dynamite_end_to_end_test 60.03% <ø> (ø) Carriedforward from 8552b83
dynamite_runtime 85.40% <ø> (ø) Carriedforward from 8552b83
neon_dashboard 96.20% <ø> (ø)
neon_framework 44.60% <0.00%> (-0.10%) ⬇️
neon_notifications 100.00% <ø> (ø)
neon_talk 98.94% <ø> (ø)
nextcloud 26.28% <ø> (ø) Carriedforward from 8552b83
sort_box 90.90% <ø> (ø) Carriedforward from 8552b83

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...es/neon_framework/lib/src/pages/login_qr_code.dart 7.40% <0.00%> (ø)
packages/neon_framework/lib/src/router.g.dart 0.00% <0.00%> (ø)
packages/neon_framework/lib/src/router.dart 4.34% <0.00%> (+0.06%) ⬆️

@Leptopoda
Copy link
Member

Can we unit teat this?

@provokateurin
Copy link
Member Author

I don't know how to make a regression test for this kind of change.

@provokateurin provokateurin merged commit 8f54595 into main Jul 13, 2024
8 of 10 checks passed
@provokateurin provokateurin deleted the fix/neon_framework/qrcode-login-routes branch July 13, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QR login broken
2 participants