Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(nextcloud): Remove expect skip #2261

Merged
merged 1 commit into from
Jul 14, 2024

Conversation

provokateurin
Copy link
Member

A skip in an expect will make the test retry which of course doesn't change anything. Also it should ensure the value, even if it is null, instead of ignoring it.

Signed-off-by: provokateurin <kate@provokateurin.de>
@provokateurin provokateurin enabled auto-merge July 12, 2024 19:37
Copy link

codecov bot commented Jul 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.68%. Comparing base (9185cd2) to head (4875a12).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2261   +/-   ##
=======================================
  Coverage   29.68%   29.68%           
=======================================
  Files         259      259           
  Lines       94757    94757           
=======================================
  Hits        28124    28124           
  Misses      66633    66633           
Flag Coverage Δ *Carryforward flag
cookie_store 90.51% <ø> (ø) Carriedforward from 8552b83
dynamite 31.10% <ø> (ø) Carriedforward from 8552b83
dynamite_end_to_end_test 60.03% <ø> (ø) Carriedforward from 8552b83
dynamite_runtime 85.40% <ø> (ø) Carriedforward from 8552b83
neon_dashboard 96.20% <ø> (ø)
neon_framework 44.70% <ø> (ø)
neon_notifications 100.00% <ø> (ø)
neon_talk 98.94% <ø> (ø)
nextcloud 26.28% <ø> (ø)
sort_box 90.90% <ø> (ø) Carriedforward from 8552b83

*This pull request uses carry forward flags. Click here to find out more.

@provokateurin provokateurin merged commit 562e2cf into main Jul 14, 2024
10 checks passed
@provokateurin provokateurin deleted the test/nextcloud/remove-expect-skip branch July 14, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants