Skip to content

fix(dynamite): Add missing docs about request body #2269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2024

Conversation

provokateurin
Copy link
Member

Fixes #2240

@provokateurin provokateurin requested a review from Leptopoda July 14, 2024 12:06
Signed-off-by: provokateurin <kate@provokateurin.de>
@provokateurin provokateurin force-pushed the fix/dynamite/request-body-docs branch from e606d3d to 1be3744 Compare July 14, 2024 12:15
Copy link

codecov bot commented Jul 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 30.99%. Comparing base (2d8d0d3) to head (1be3744).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2269      +/-   ##
==========================================
+ Coverage   30.20%   30.99%   +0.79%     
==========================================
  Files         262      263       +1     
  Lines       96598    97093     +495     
==========================================
+ Hits        29177    30094     +917     
+ Misses      67421    66999     -422     
Flag Coverage Δ *Carryforward flag
cookie_store 90.51% <ø> (ø) Carriedforward from a9b3ead
dynamite 31.08% <0.00%> (-0.03%) ⬇️
dynamite_end_to_end_test 60.96% <ø> (+0.92%) ⬆️
dynamite_runtime 85.40% <ø> (ø) Carriedforward from a9b3ead
neon_dashboard 96.20% <ø> (ø)
neon_framework 44.60% <ø> (ø)
neon_notifications 100.00% <ø> (ø)
neon_talk 98.94% <ø> (ø)
nextcloud 27.67% <ø> (+0.70%) ⬆️
sort_box 90.90% <ø> (ø) Carriedforward from a9b3ead

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...ckages/nextcloud/lib/src/api/cookbook.openapi.dart 95.45% <ø> (ø)
...ite/dynamite/lib/src/models/openapi/operation.dart 2.43% <0.00%> (-0.13%) ⬇️

... and 8 files with indirect coverage changes

@provokateurin provokateurin merged commit c984cf3 into main Jul 14, 2024
9 of 10 checks passed
@provokateurin provokateurin deleted the fix/dynamite/request-body-docs branch July 14, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Body parameter has no doc comment
2 participants