-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(neon_talk): Enable editing of chat messages #2277
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2277 +/- ##
==========================================
+ Coverage 30.92% 31.15% +0.22%
==========================================
Files 265 265
Lines 96710 96773 +63
==========================================
+ Hits 29907 30145 +238
+ Misses 66803 66628 -175
*This pull request uses carry forward flags. Click here to find out more.
|
826988e
to
d3978f7
Compare
Editing messages is only a feature since Talk 19, so the check for the feature needs to be implemented using the capabilities. |
d3978f7
to
7ac8f48
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes look good overall :)
Signed-off-by: provokateurin <kate@provokateurin.de>
Signed-off-by: provokateurin <kate@provokateurin.de>
Signed-off-by: provokateurin <kate@provokateurin.de>
Signed-off-by: provokateurin <kate@provokateurin.de>
Signed-off-by: provokateurin <kate@provokateurin.de>
7ac8f48
to
45e423e
Compare
Closes #2071