Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(neon_talk): Request file previews in a sensible resoltion if none is provided #2280

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

provokateurin
Copy link
Member

No description provided.

… is provided

Signed-off-by: provokateurin <kate@provokateurin.de>
@provokateurin provokateurin requested a review from Leptopoda July 16, 2024 15:22
Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 30.85%. Comparing base (6c7be4c) to head (b0d4e08).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2280   +/-   ##
=======================================
  Coverage   30.85%   30.85%           
=======================================
  Files         262      262           
  Lines       96596    96598    +2     
=======================================
+ Hits        29802    29804    +2     
  Misses      66794    66794           
Flag Coverage Δ *Carryforward flag
cookie_store 90.51% <ø> (ø) Carriedforward from 6c7be4c
dynamite 31.10% <ø> (ø) Carriedforward from 6c7be4c
dynamite_end_to_end_test 60.03% <ø> (ø) Carriedforward from 6c7be4c
dynamite_runtime 85.40% <ø> (ø) Carriedforward from 6c7be4c
neon_dashboard 96.20% <ø> (ø) Carriedforward from 6c7be4c
neon_framework 45.78% <ø> (ø) Carriedforward from 6c7be4c
neon_notifications 100.00% <ø> (ø) Carriedforward from 6c7be4c
neon_talk 98.94% <100.00%> (+<0.01%) ⬆️
nextcloud 27.67% <ø> (ø) Carriedforward from 6c7be4c
sort_box 90.90% <ø> (ø) Carriedforward from 6c7be4c

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...talk/lib/src/widgets/rich_object/file_preview.dart 100.00% <100.00%> (ø)

@provokateurin provokateurin merged commit bff5516 into main Jul 16, 2024
10 checks passed
@provokateurin provokateurin deleted the fix/neon_talk/file-preview-fallback-resolution branch July 16, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants