Skip to content

feat(neon_talk): Add helpers for parsing timestamps #2287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

provokateurin
Copy link
Member

No description provided.

@provokateurin provokateurin requested a review from Leptopoda July 18, 2024 06:49
@Leptopoda
Copy link
Member

I'm not sure if this should be in the nextcloud package.
Is there anything against having it in neon_talk?

@provokateurin
Copy link
Member Author

Not really, but the helpers can be useful for other people as well, so I don't see why they shouldn't be in the nextcloud package.

Copy link

codecov bot commented Jul 18, 2024

Codecov Report

Attention: Patch coverage is 44.44444% with 5 lines in your changes missing coverage. Please review.

Project coverage is 30.92%. Comparing base (c624c39) to head (4c6fe24).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2287      +/-   ##
==========================================
- Coverage   30.92%   30.92%   -0.01%     
==========================================
  Files         265      265              
  Lines       96709    96710       +1     
==========================================
- Hits        29911    29907       -4     
- Misses      66798    66803       +5     
Flag Coverage Δ *Carryforward flag
cookie_store 90.51% <ø> (ø) Carriedforward from c624c39
dynamite 31.10% <ø> (ø) Carriedforward from c624c39
dynamite_end_to_end_test 60.03% <ø> (ø) Carriedforward from c624c39
dynamite_runtime 85.40% <ø> (ø) Carriedforward from c624c39
neon_dashboard 96.20% <ø> (ø) Carriedforward from c624c39
neon_framework 45.90% <ø> (ø) Carriedforward from c624c39
neon_notifications 100.00% <ø> (ø) Carriedforward from c624c39
neon_talk 98.18% <44.44%> (-0.48%) ⬇️
nextcloud 27.67% <ø> (ø) Carriedforward from c624c39
sort_box 90.90% <ø> (ø) Carriedforward from c624c39

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
packages/neon/neon_talk/lib/src/pages/room.dart 100.00% <100.00%> (ø)
...ckages/neon/neon_talk/lib/src/widgets/message.dart 98.51% <100.00%> (-0.03%) ⬇️
packages/neon/neon_talk/lib/src/utils/helpers.dart 28.57% <16.66%> (-71.43%) ⬇️

@Leptopoda
Copy link
Member

I'd rather not have them in the nextcloud package, as these fields offer a quite different experience to the rest of the BuiltValue models.

These extensions are not cached, so multiple requests will lead to parsing the time multiple times.
It might also be confusing that to change the time one has to change the string representation.
Yes a quick look at the code will make that clear but I only see a point of cocnfusion.

Signed-off-by: provokateurin <kate@provokateurin.de>
@provokateurin provokateurin force-pushed the feat/nextcloud/spreed-timestamp-helpers branch from 535148f to 4c6fe24 Compare July 18, 2024 14:11
@provokateurin provokateurin changed the title feat(nextcloud): Add spreed helpers for parsing timestamps feat(neon_talk): Add helpers for parsing timestamps Jul 18, 2024
@provokateurin provokateurin enabled auto-merge July 18, 2024 14:11
@provokateurin provokateurin merged commit 3efd5dc into main Jul 18, 2024
10 checks passed
@provokateurin provokateurin deleted the feat/nextcloud/spreed-timestamp-helpers branch July 18, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants