Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nextcloud_test): Skip CSRF token requests in fixtures #2293

Merged
merged 1 commit into from
Jul 21, 2024

Conversation

provokateurin
Copy link
Member

Needed for #1901

Signed-off-by: provokateurin <kate@provokateurin.de>
@provokateurin provokateurin requested a review from Leptopoda July 21, 2024 07:12
Copy link

codecov bot commented Jul 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 30.92%. Comparing base (85c8071) to head (f3bdd04).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2293   +/-   ##
=======================================
  Coverage   30.92%   30.92%           
=======================================
  Files         265      265           
  Lines       96710    96710           
=======================================
  Hits        29907    29907           
  Misses      66803    66803           
Flag Coverage Δ *Carryforward flag
cookie_store 90.51% <ø> (ø) Carriedforward from 85c8071
dynamite 31.10% <ø> (ø) Carriedforward from 85c8071
dynamite_end_to_end_test 60.03% <ø> (ø) Carriedforward from 85c8071
dynamite_runtime 85.40% <ø> (ø) Carriedforward from 85c8071
neon_dashboard 96.20% <ø> (ø)
neon_framework 45.90% <ø> (ø)
neon_notifications 100.00% <ø> (ø)
neon_talk 98.18% <ø> (ø)
nextcloud 27.67% <ø> (ø)
sort_box 90.90% <ø> (ø) Carriedforward from 85c8071

*This pull request uses carry forward flags. Click here to find out more.

@Leptopoda
Copy link
Member

Why exactly is this needed?

@provokateurin
Copy link
Member Author

This messes with the order of tests, since we only acquire a token once. This means the request is only present in the fixture of the first test that runs. Now if the order is changed (e.g. using a random seed) the fixtures will fail.

@provokateurin provokateurin merged commit 2108645 into main Jul 21, 2024
10 checks passed
@provokateurin provokateurin deleted the fix/nextcloud_test/fixture-csrf-requests branch July 21, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants