-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(neon_http_client): add csrf interceptor #2300
Conversation
a34d1e8
to
447c515
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2300 +/- ##
==========================================
+ Coverage 28.93% 29.74% +0.81%
==========================================
Files 275 293 +18
Lines 108625 117527 +8902
==========================================
+ Hits 31428 34960 +3532
- Misses 77197 82567 +5370
*This pull request uses carry forward flags. Click here to find out more.
|
Wasn't there a reason why we used flutter for running tests to collect coverage? I remember something wasn't working, but can't find the PR anymore. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected, but please check my last comment before merging.
The way we collected the coverage before was broken and I think that you mainly wanted to unify both test cases. what do you think? |
Please break the tests on purpose to ensure the job will fail, since that was one of the problems we had before |
this allows us to easily run tests in the browser Signed-off-by: Nikolas Rimikis <leptopoda@users.noreply.github.com>
Signed-off-by: Nikolas Rimikis <leptopoda@users.noreply.github.com>
447c515
to
10e53ff
Compare
Thanks for the test, seems like the CI will still fail properly 👍 |
10e53ff
to
27c5f57
Compare
The coverage is a bit different from the one reported by the
flutter_test
package, as they both use different coverage collectors.Let's hope it won't be too off from the current one