Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nextcloud_test): Add local test target #2323

Merged
merged 5 commits into from
Jul 28, 2024

Conversation

provokateurin
Copy link
Member

Closes #1901

I can split this PR into multiple ones if desired.

Removing the maximum version check is done because major versions of apps don't necessarily indicate incompatible APIs. In fact, none of the existing APIs should ever have breaking changes except for cases when they are removed which also shouldn't happen.

I validated that the latest version of the server an all relevant apps work just fine with our current tests 🎉

Signed-off-by: provokateurin <kate@provokateurin.de>
Signed-off-by: provokateurin <kate@provokateurin.de>
Signed-off-by: provokateurin <kate@provokateurin.de>
@provokateurin provokateurin requested a review from Leptopoda July 27, 2024 12:38
Copy link

codecov bot commented Jul 27, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 29.75%. Comparing base (b246d89) to head (377246b).
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2323   +/-   ##
=======================================
  Coverage   29.74%   29.75%           
=======================================
  Files         293      293           
  Lines      117527   117540   +13     
=======================================
+ Hits        34959    34973   +14     
+ Misses      82568    82567    -1     
Flag Coverage Δ *Carryforward flag
cookie_store 100.00% <ø> (ø) Carriedforward from bc4fbc2
dynamite 31.08% <ø> (ø) Carriedforward from bc4fbc2
dynamite_end_to_end_test 60.96% <ø> (ø) Carriedforward from bc4fbc2
dynamite_runtime 85.40% <ø> (ø) Carriedforward from bc4fbc2
neon_dashboard 96.20% <ø> (ø)
neon_framework 45.85% <0.00%> (ø)
neon_http_client 93.28% <ø> (ø)
neon_notifications 100.00% <ø> (ø)
neon_talk 99.46% <ø> (+<0.01%) ⬆️
nextcloud 26.64% <100.00%> (-0.01%) ⬇️
sort_box 90.90% <ø> (ø) Carriedforward from bc4fbc2

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...xtcloud/lib/src/api/cookbook/cookbook_helpers.dart 100.00% <ø> (ø)
...kages/nextcloud/lib/src/api/core/core_helpers.dart 100.00% <ø> (ø)
...kages/nextcloud/lib/src/api/news/news_helpers.dart 100.00% <ø> (ø)
...ges/nextcloud/lib/src/api/notes/notes_helpers.dart 100.00% <ø> (ø)
...s/nextcloud/lib/src/api/spreed/spreed_helpers.dart 80.95% <ø> (ø)
...s/nextcloud/lib/src/api/tables/tables_helpers.dart 100.00% <ø> (ø)
...ckages/nextcloud/lib/src/models/version_check.dart 64.70% <100.00%> (-0.30%) ⬇️
packages/neon_framework/lib/src/pages/home.dart 0.00% <0.00%> (ø)

Copy link
Member

@Leptopoda Leptopoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the abstraction between the docker and local version :)
Nice work 👍

packages/nextcloud/doc/development.md Outdated Show resolved Hide resolved
@provokateurin provokateurin force-pushed the feat/nextcloud_test/local-testing branch from 0df8e50 to 377246b Compare July 28, 2024 07:40
@provokateurin provokateurin requested a review from Leptopoda July 28, 2024 07:40
Signed-off-by: provokateurin <kate@provokateurin.de>
Signed-off-by: provokateurin <kate@provokateurin.de>
@provokateurin provokateurin force-pushed the feat/nextcloud_test/local-testing branch from 377246b to 3cbecec Compare July 28, 2024 08:20
@provokateurin provokateurin enabled auto-merge July 28, 2024 08:21
@provokateurin provokateurin merged commit 297fb41 into main Jul 28, 2024
8 checks passed
@provokateurin provokateurin deleted the feat/nextcloud_test/local-testing branch July 28, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make it possible to run tests against a git checkout of server and the apps
2 participants