-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(nextcloud_test): Add local test target #2323
Conversation
Signed-off-by: provokateurin <kate@provokateurin.de>
Signed-off-by: provokateurin <kate@provokateurin.de>
Signed-off-by: provokateurin <kate@provokateurin.de>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2323 +/- ##
=======================================
Coverage 29.74% 29.75%
=======================================
Files 293 293
Lines 117527 117540 +13
=======================================
+ Hits 34959 34973 +14
+ Misses 82568 82567 -1
*This pull request uses carry forward flags. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like the abstraction between the docker and local version :)
Nice work 👍
0df8e50
to
377246b
Compare
Signed-off-by: provokateurin <kate@provokateurin.de>
Signed-off-by: provokateurin <kate@provokateurin.de>
377246b
to
3cbecec
Compare
Closes #1901
I can split this PR into multiple ones if desired.
Removing the maximum version check is done because major versions of apps don't necessarily indicate incompatible APIs. In fact, none of the existing APIs should ever have breaking changes except for cases when they are removed which also shouldn't happen.
I validated that the latest version of the server an all relevant apps work just fine with our current tests 🎉