Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(nextcloud_test): unify test instance handling #2325

Merged

Conversation

Leptopoda
Copy link
Member

Why?

  1. this cleans up the tests themselves, as they no longer need to handle the client creation and target lifecycle.
  2. The tests can be split into multiple files (maybe per sub client) for better structure

@Leptopoda
Copy link
Member Author

Leptopoda commented Jul 28, 2024

Making the test factory a singleton is not strictly needed, as the NextcloudTester could handle the creation and lifecycle.
But IMO there is no need for running tests against two backends (docker and local) at the same time.

Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice cleanups, thank you 👍

Copy link

codecov bot commented Jul 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.85%. Comparing base (07d1eba) to head (9cffb7d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2325   +/-   ##
=======================================
  Coverage   29.85%   29.85%           
=======================================
  Files         293      293           
  Lines      117895   117895           
=======================================
  Hits        35196    35196           
  Misses      82699    82699           
Flag Coverage Δ *Carryforward flag
cookie_store 100.00% <ø> (ø) Carriedforward from 07d1eba
dynamite 31.08% <ø> (ø) Carriedforward from 07d1eba
dynamite_end_to_end_test 60.96% <ø> (ø) Carriedforward from 07d1eba
dynamite_runtime 85.40% <ø> (ø) Carriedforward from 07d1eba
neon_dashboard 96.20% <ø> (ø)
neon_framework 45.85% <ø> (ø)
neon_http_client 93.28% <ø> (ø)
neon_notifications 100.00% <ø> (ø)
neon_talk 99.46% <ø> (ø)
nextcloud 26.76% <ø> (ø)
sort_box 90.90% <ø> (ø) Carriedforward from 07d1eba

*This pull request uses carry forward flags. Click here to find out more.

Signed-off-by: Nikolas Rimikis <leptopoda@users.noreply.github.com>
…presets

Signed-off-by: Nikolas Rimikis <leptopoda@users.noreply.github.com>
@Leptopoda Leptopoda force-pushed the refactor/nextcloud_test/unified_test_instance_handling branch from 261b065 to 8dec1df Compare July 28, 2024 12:44
@Leptopoda Leptopoda requested a review from provokateurin July 28, 2024 12:45
Signed-off-by: Nikolas Rimikis <leptopoda@users.noreply.github.com>
Signed-off-by: Nikolas Rimikis <leptopoda@users.noreply.github.com>
Signed-off-by: Nikolas Rimikis <leptopoda@users.noreply.github.com>
Signed-off-by: Nikolas Rimikis <leptopoda@users.noreply.github.com>
@Leptopoda Leptopoda force-pushed the refactor/nextcloud_test/unified_test_instance_handling branch from 8dec1df to 9cffb7d Compare July 28, 2024 12:55
@Leptopoda Leptopoda merged commit d8af245 into main Jul 28, 2024
10 checks passed
@Leptopoda Leptopoda deleted the refactor/nextcloud_test/unified_test_instance_handling branch July 28, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants