-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(nextcloud_test): unify test instance handling #2325
refactor(nextcloud_test): unify test instance handling #2325
Conversation
Making the test factory a singleton is not strictly needed, as the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice cleanups, thank you 👍
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2325 +/- ##
=======================================
Coverage 29.85% 29.85%
=======================================
Files 293 293
Lines 117895 117895
=======================================
Hits 35196 35196
Misses 82699 82699
*This pull request uses carry forward flags. Click here to find out more. |
Signed-off-by: Nikolas Rimikis <leptopoda@users.noreply.github.com>
…presets Signed-off-by: Nikolas Rimikis <leptopoda@users.noreply.github.com>
261b065
to
8dec1df
Compare
Signed-off-by: Nikolas Rimikis <leptopoda@users.noreply.github.com>
Signed-off-by: Nikolas Rimikis <leptopoda@users.noreply.github.com>
Signed-off-by: Nikolas Rimikis <leptopoda@users.noreply.github.com>
Signed-off-by: Nikolas Rimikis <leptopoda@users.noreply.github.com>
8dec1df
to
9cffb7d
Compare
Why?