-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: change package file structure #2350
Conversation
174b69c
to
ac36f75
Compare
What about moving the |
I agree with dynamite, but am unsure about the neon_* ones. |
I see, they are a bit weird. BTW you also need to fix all the paths in tool/ and any documentation. |
Maybe cookie_store should go into neon_http_client? OTOH it is a pretty standalone package that we could publish at some point so that others can use it too. |
ac36f75
to
7fc4694
Compare
I've tried my best to search for all packages I changed and hope I didn't miss any.
Let's leave it there for now. |
e5447fb
to
65db780
Compare
65db780
to
aa8ab1b
Compare
Instead of making a long and tedious review I just fixed all the problems. I found quite a few, but I think now everything is fixed. |
@Leptopoda Let me know if you find my changes good, then I'll approve and we can merge 🚀 |
BTW I already love working with this structure, it is so much better than what we had before! ❤️ |
aa8ab1b
to
b273799
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2350 +/- ##
==========================================
+ Coverage 25.58% 26.29% +0.71%
==========================================
Files 334 362 +28
Lines 135147 136468 +1321
==========================================
+ Hits 34582 35889 +1307
- Misses 100565 100579 +14
*This pull request uses carry forward flags. Click here to find out more.
|
b273799
to
eb4be19
Compare
96dc869
to
893052e
Compare
893052e
to
2e1d815
Compare
Signed-off-by: Nikolas Rimikis <leptopoda@users.noreply.github.com> Signed-off-by: provokateurin <kate@provokateurin.de>
Signed-off-by: Nikolas Rimikis <leptopoda@users.noreply.github.com> Signed-off-by: provokateurin <kate@provokateurin.de>
2e1d815
to
72b50ac
Compare
🎉 |
I didn't know what to do with the cookie_store packages.
Should I move them to the framework, or just keep them as they are?