Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: change package file structure #2350

Merged
merged 2 commits into from
Aug 15, 2024
Merged

Conversation

Leptopoda
Copy link
Member

I didn't know what to do with the cookie_store packages.
Should I move them to the framework, or just keep them as they are?

@Leptopoda Leptopoda requested a review from provokateurin August 5, 2024 10:21
@Leptopoda Leptopoda force-pushed the refactor/package_structure branch from 174b69c to ac36f75 Compare August 5, 2024 10:22
@provokateurin
Copy link
Member

What about moving the packages/neon/neon_* packages to packages/neon_framework/packages and packages/dynamite/dynamite_* to packages/dynamite/packages?

@Leptopoda
Copy link
Member Author

I agree with dynamite, but am unsure about the neon_* ones.
With my proposed way, each $consumer/packages contains the packages that are needed for $consumer while moving them into the framework would switch that up.

@provokateurin
Copy link
Member

I see, they are a bit weird.

BTW you also need to fix all the paths in tool/ and any documentation.

@provokateurin
Copy link
Member

Maybe cookie_store should go into neon_http_client? OTOH it is a pretty standalone package that we could publish at some point so that others can use it too.

@Leptopoda Leptopoda force-pushed the refactor/package_structure branch from ac36f75 to 7fc4694 Compare August 8, 2024 14:20
@Leptopoda
Copy link
Member Author

BTW you also need to fix all the paths in tool/ and any documentation.

I've tried my best to search for all packages I changed and hope I didn't miss any.

Maybe cookie_store should go into neon_http_client?

Let's leave it there for now.

@Leptopoda Leptopoda force-pushed the refactor/package_structure branch 3 times, most recently from e5447fb to 65db780 Compare August 14, 2024 20:30
@provokateurin provokateurin force-pushed the refactor/package_structure branch from 65db780 to aa8ab1b Compare August 14, 2024 22:43
@provokateurin
Copy link
Member

Instead of making a long and tedious review I just fixed all the problems. I found quite a few, but I think now everything is fixed.

@provokateurin
Copy link
Member

@Leptopoda Let me know if you find my changes good, then I'll approve and we can merge 🚀

@provokateurin
Copy link
Member

BTW I already love working with this structure, it is so much better than what we had before! ❤️

@provokateurin provokateurin force-pushed the refactor/package_structure branch from aa8ab1b to b273799 Compare August 14, 2024 22:55
Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.29%. Comparing base (0c57d2e) to head (72b50ac).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2350      +/-   ##
==========================================
+ Coverage   25.58%   26.29%   +0.71%     
==========================================
  Files         334      362      +28     
  Lines      135147   136468    +1321     
==========================================
+ Hits        34582    35889    +1307     
- Misses     100565   100579      +14     
Flag Coverage Δ *Carryforward flag
cookie_store 100.00% <ø> (ø)
dashboard_app 96.05% <ø> (?)
dynamite 31.08% <ø> (ø)
dynamite_end_to_end_test 61.84% <ø> (ø)
dynamite_runtime 85.40% <ø> (ø)
neon_dashboard 96.05% <ø> (ø) Carriedforward from 216224d
neon_framework 45.83% <ø> (+<0.01%) ⬆️
neon_http_client 93.28% <ø> (ø)
neon_notifications 100.00% <ø> (ø) Carriedforward from 216224d
neon_talk 99.45% <ø> (+<0.01%) ⬆️ Carriedforward from 216224d
nextcloud 22.29% <ø> (ø)
notifications_app 100.00% <ø> (?)
sort_box 90.90% <ø> (ø)
talk_app 99.36% <ø> (?)

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...ackages/dynamite/lib/src/helpers/dart_helpers.dart 41.37% <ø> (ø)
...ckages/dynamite/lib/src/helpers/default_value.dart 0.00% <ø> (ø)
packages/dynamite/lib/src/helpers/docs.dart 0.00% <ø> (ø)
packages/dynamite/lib/src/helpers/logger.dart 0.00% <ø> (ø)
packages/dynamite/lib/src/models/exceptions.dart 0.00% <ø> (ø)
packages/dynamite/lib/src/models/json_schema.dart 100.00% <ø> (ø)
...ackages/dynamite/lib/src/models/json_schema.g.dart 98.27% <ø> (ø)
...namite/lib/src/models/json_schema/annotations.dart 0.00% <ø> (ø)
...es/dynamite/lib/src/models/json_schema/schema.dart 82.30% <ø> (ø)
.../dynamite/lib/src/models/json_schema/schema.g.dart 39.60% <ø> (ø)
... and 79 more

... and 43 files with indirect coverage changes

@Leptopoda Leptopoda force-pushed the refactor/package_structure branch from b273799 to eb4be19 Compare August 15, 2024 07:27
@provokateurin provokateurin force-pushed the refactor/package_structure branch 2 times, most recently from 96dc869 to 893052e Compare August 15, 2024 07:38
@provokateurin provokateurin force-pushed the refactor/package_structure branch from 893052e to 2e1d815 Compare August 15, 2024 08:47
Signed-off-by: Nikolas Rimikis <leptopoda@users.noreply.github.com>
Signed-off-by: provokateurin <kate@provokateurin.de>
Signed-off-by: Nikolas Rimikis <leptopoda@users.noreply.github.com>
Signed-off-by: provokateurin <kate@provokateurin.de>
@provokateurin provokateurin force-pushed the refactor/package_structure branch from 2e1d815 to 72b50ac Compare August 15, 2024 08:48
@Leptopoda Leptopoda merged commit 0d5985b into main Aug 15, 2024
10 checks passed
@Leptopoda Leptopoda deleted the refactor/package_structure branch August 15, 2024 09:58
@provokateurin
Copy link
Member

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants