Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nextcloud)!: Revert request body usage for non-PUT/POST/PATCH requests #2352

Merged
merged 2 commits into from
Aug 6, 2024

Conversation

provokateurin
Copy link
Member

@provokateurin provokateurin commented Aug 5, 2024

#2129
#2305

While the change is technically not breaking because the previous change wasn't released yet, this makes it easier to find the change in the changelog and understand what has happened.

@provokateurin provokateurin requested a review from Leptopoda August 5, 2024 14:12
@provokateurin provokateurin marked this pull request as draft August 5, 2024 15:13
Copy link
Member

@Leptopoda Leptopoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Is there a reason for this still being a draft?

@provokateurin
Copy link
Member Author

CI was failing because I only adjusted the nextcloud tests and not the bloc tests

Signed-off-by: provokateurin <kate@provokateurin.de>
…uests

Signed-off-by: provokateurin <kate@provokateurin.de>
@provokateurin provokateurin force-pushed the fix/nextcloud/request-body branch from bbd506d to 52f868d Compare August 6, 2024 07:03
@provokateurin provokateurin marked this pull request as ready for review August 6, 2024 07:03
@provokateurin provokateurin enabled auto-merge August 6, 2024 07:03
Copy link

codecov bot commented Aug 6, 2024

Codecov Report

Attention: Patch coverage is 15.64792% with 345 lines in your changes missing coverage. Please review.

Project coverage is 25.46%. Comparing base (da4bff1) to head (52f868d).
Report is 3 commits behind head on main.

Files Patch % Lines
...b/src/api/files_sharing/files_sharing.openapi.dart 6.45% 87 Missing ⚠️
...api/provisioning_api/provisioning_api.openapi.dart 6.66% 56 Missing ⚠️
...nextcloud/lib/src/api/theming/theming.openapi.dart 12.50% 42 Missing ⚠️
...i/provisioning_api/provisioning_api.openapi.g.dart 0.00% 30 Missing ⚠️
...src/api/files_trashbin/files_trashbin.openapi.dart 6.66% 28 Missing ⚠️
...s/nextcloud/lib/src/api/tables/tables.openapi.dart 0.00% 19 Missing ⚠️
...src/api/files_sharing/files_sharing.openapi.g.dart 0.00% 18 Missing ⚠️
...xtcloud/lib/src/api/theming/theming.openapi.g.dart 0.00% 18 Missing ⚠️
...src/api/files_versions/files_versions.openapi.dart 0.00% 16 Missing ⚠️
...cloud/lib/src/api/user_ldap/user_ldap.openapi.dart 12.50% 14 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2352      +/-   ##
==========================================
+ Coverage   25.23%   25.46%   +0.23%     
==========================================
  Files         333      333              
  Lines      140016   134828    -5188     
==========================================
- Hits        35331    34336     -995     
+ Misses     104685   100492    -4193     
Flag Coverage Δ *Carryforward flag
cookie_store 100.00% <ø> (ø) Carriedforward from da4bff1
dynamite 31.08% <ø> (ø) Carriedforward from da4bff1
dynamite_end_to_end_test 60.96% <ø> (ø) Carriedforward from da4bff1
dynamite_runtime 85.40% <ø> (ø) Carriedforward from da4bff1
neon_dashboard 96.05% <100.00%> (-0.15%) ⬇️
neon_framework 45.81% <100.00%> (-0.04%) ⬇️
neon_http_client 93.28% <ø> (ø)
neon_notifications 100.00% <ø> (ø)
neon_talk 99.45% <100.00%> (-0.01%) ⬇️
nextcloud 22.29% <12.65%> (+0.14%) ⬆️
sort_box 90.90% <ø> (ø) Carriedforward from da4bff1

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...s/neon/neon_dashboard/lib/src/blocs/dashboard.dart 100.00% <100.00%> (ø)
packages/neon/neon_talk/lib/src/blocs/room.dart 98.52% <100.00%> (-0.09%) ⬇️
.../neon/neon_talk/lib/src/widgets/message_input.dart 98.56% <100.00%> (-0.04%) ⬇️
...talk/lib/src/widgets/rich_object/file_preview.dart 100.00% <100.00%> (ø)
...s/neon_framework/lib/src/blocs/unified_search.dart 100.00% <100.00%> (ø)
...es/neon_framework/lib/src/testing/mock_server.dart 91.66% <100.00%> (ø)
...s/neon_framework/lib/src/widgets/autocomplete.dart 100.00% <100.00%> (+2.27%) ⬆️
...kages/nextcloud/lib/src/api/core/core.openapi.dart 45.44% <ø> (+0.07%) ⬆️
...ges/nextcloud/lib/src/api/core/core.openapi.g.dart 29.21% <ø> (+0.04%) ⬆️
...cloud/lib/src/api/dashboard/dashboard.openapi.dart 86.61% <100.00%> (+1.63%) ⬆️
... and 21 more

... and 7 files with indirect coverage changes

@provokateurin provokateurin merged commit 1496cdd into main Aug 6, 2024
9 of 10 checks passed
@provokateurin provokateurin deleted the fix/nextcloud/request-body branch August 6, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants