Skip to content

refactor(cookie_store): remove universal_io dependency. #2413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Leptopoda merged 1 commit into from
Aug 21, 2024
Merged

refactor(cookie_store): remove universal_io dependency. #2413

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions packages/cookie_store/dart_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
platforms:
- vm
- chrome

define_platforms:
chromium:
name: Chromium
extends: chrome
settings:
executable: chromium
2 changes: 1 addition & 1 deletion packages/cookie_store/lib/src/cookie_persistence.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import 'dart:async';
import 'dart:io' show Cookie;

import 'package:cookie_store/src/storable_cookie.dart';
import 'package:cookie_store/src/utils.dart';
import 'package:timezone/timezone.dart' as tz;
import 'package:universal_io/io.dart' show Cookie;

/// Interface for a Storage backend persisting [StorableCookie]s.
///
Expand Down
2 changes: 1 addition & 1 deletion packages/cookie_store/lib/src/cookie_store.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
// ignore_for_file: prefer_final_locals, omit_local_variable_types

import 'dart:async';
import 'dart:io' show Cookie;

import 'package:cookie_store/src/cookie_persistence.dart';
import 'package:cookie_store/src/storable_cookie.dart';
import 'package:cookie_store/src/utils.dart';
import 'package:timezone/timezone.dart' as tz;
import 'package:universal_io/io.dart' show Cookie;

// DateTimes can represent time values that are at a distance of at most 100,000,000
// days from epoch (1970-01-01 UTC): -271821-04-20 to 275760-09-13.
Expand Down
3 changes: 2 additions & 1 deletion packages/cookie_store/packages/cookie_store_conformance_tests/lib/src/utils.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import 'dart:io' show Cookie, SameSite;

import 'package:meta/meta.dart';
import 'package:universal_io/io.dart';

/// Converts the given cookies to strings containing only the [Cookie.name] and
/// `Cookie.vale` and sorts the resulting list.
Expand Down
1 change: 0 additions & 1 deletion packages/cookie_store/packages/cookie_store_conformance_tests/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ dependencies:
path: packages/cookie_store
meta: ^1.0.0
test: ^1.21.2
universal_io: ^2.0.0

dev_dependencies:
neon_lints:
Expand Down
1 change: 0 additions & 1 deletion packages/cookie_store/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ environment:
dependencies:
meta: ^1.0.0
timezone: ^0.9.4
universal_io: ^2.0.0

dev_dependencies:
cookie_store_conformance_tests:
Expand Down