Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(nextcloud)!: Remove deprecated userAgent and cookieJar parameters from NextcloudClient #2447

Merged

Conversation

provokateurin
Copy link
Member

Closes #2417

Copy link

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.87%. Comparing base (5915c57) to head (4ce78c1).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2447      +/-   ##
==========================================
+ Coverage   27.20%   29.87%   +2.66%     
==========================================
  Files         369      332      -37     
  Lines      136676   124330   -12346     
==========================================
- Hits        37189    37138      -51     
+ Misses      99487    87192   -12295     
Flag Coverage Δ *Carryforward flag
account_repository 99.64% <ø> (ø)
cookie_store 100.00% <ø> (ø) Carriedforward from 5915c57
dashboard_app 96.05% <ø> (ø)
dynamite 31.08% <ø> (ø) Carriedforward from 5915c57
dynamite_end_to_end_test 61.69% <ø> (ø) Carriedforward from 5915c57
dynamite_runtime 85.40% <ø> (ø) Carriedforward from 5915c57
neon_dashboard 96.05% <ø> (ø) Carriedforward from 5915c57
neon_framework 43.55% <ø> (ø)
neon_http_client 93.28% <ø> (ø)
neon_notifications 100.00% <ø> (ø) Carriedforward from 5915c57
neon_talk 99.45% <ø> (ø) Carriedforward from 5915c57
nextcloud 25.88% <ø> (+2.61%) ⬆️
notifications_app 100.00% <ø> (ø)
sort_box 90.90% <ø> (ø) Carriedforward from 5915c57
talk_app 99.09% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
packages/nextcloud/lib/src/nextcloud_client.dart 100.00% <ø> (ø)

... and 37 files with indirect coverage changes

Copy link
Member

@Leptopoda Leptopoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please drop the cookie_jar dependency

…rs from NextcloudClient

Signed-off-by: provokateurin <kate@provokateurin.de>
@provokateurin provokateurin force-pushed the chore/nextcloud/remove-deprecated-useragent-cookiejar branch from b78f04f to 4ce78c1 Compare August 30, 2024 08:23
Copy link
Member

@Leptopoda Leptopoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally 🎉

@provokateurin provokateurin merged commit 44179e9 into main Aug 30, 2024
10 checks passed
@provokateurin provokateurin deleted the chore/nextcloud/remove-deprecated-useragent-cookiejar branch August 30, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove deprecated userAgent and cookieJar parameters
2 participants