Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Use spacing from Row/Column instead of intersperse #2705

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

provokateurin
Copy link
Member

No description provided.

Signed-off-by: provokateurin <kate@provokateurin.de>
Signed-off-by: provokateurin <kate@provokateurin.de>
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.90%. Comparing base (becc891) to head (bfc177d).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2705      +/-   ##
==========================================
- Coverage   28.90%   28.90%   -0.01%     
==========================================
  Files         373      373              
  Lines      136652   136645       -7     
==========================================
- Hits        39503    39498       -5     
+ Misses      97149    97147       -2     
Flag Coverage Δ *Carryforward flag
account_repository 98.47% <ø> (ø)
cookie_store 99.48% <ø> (ø)
dashboard_app 96.05% <ø> (ø)
dynamite 31.05% <ø> (ø)
dynamite_end_to_end_test 61.69% <ø> (ø)
dynamite_runtime 85.40% <ø> (ø)
interceptor_http_client 97.18% <ø> (ø)
neon_dashboard 96.05% <ø> (ø) Carriedforward from becc891
neon_framework 59.34% <ø> (+0.01%) ⬆️
neon_http_client 94.32% <ø> (+0.70%) ⬆️
neon_notifications 100.00% <ø> (ø) Carriedforward from becc891
neon_rich_text 100.00% <ø> (ø)
neon_storage 94.66% <ø> (ø)
neon_talk 99.45% <ø> (ø) Carriedforward from becc891
nextcloud 24.33% <ø> (ø)
notifications_app 97.36% <ø> (-0.07%) ⬇️
notifications_push_repository 98.11% <ø> (ø)
sort_box 90.90% <ø> (ø)
talk_app 98.83% <ø> (-0.01%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...s/neon_framework/lib/src/widgets/account_tile.dart 0.00% <ø> (ø)
...otifications_app/lib/src/widgets/notification.dart 95.55% <ø> (-0.19%) ⬇️
...ramework/packages/talk_app/lib/src/pages/room.dart 100.00% <ø> (ø)
...ork/packages/talk_app/lib/src/widgets/message.dart 98.75% <ø> (-0.02%) ⬇️

... and 1 file with indirect coverage changes

@Leptopoda
Copy link
Member

Are you sure the first commit should be a fix?

@provokateurin
Copy link
Member Author

@provokateurin provokateurin merged commit 61a60c7 into main Dec 12, 2024
11 checks passed
@provokateurin provokateurin deleted the refactor/spacing branch December 12, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants