Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(nextcloud): Add spreed #980

Merged
merged 5 commits into from
Oct 30, 2023
Merged

feat(nextcloud): Add spreed #980

merged 5 commits into from
Oct 30, 2023

Conversation

provokateurin
Copy link
Member

@provokateurin provokateurin commented Oct 16, 2023 •
edited
Loading

Towards #366

@provokateurin provokateurin marked this pull request as draft October 16, 2023 20:18
@provokateurin provokateurin force-pushed the feature/nextcloud/spreed branch from 1bd54ca to c53c709 Compare October 28, 2023 06:26
@provokateurin provokateurin marked this pull request as ready for review October 28, 2023 06:26
@provokateurin
Copy link
Member Author

The last patch is applied from nextcloud/spreed#10804 and this PR thus depends on that PR.

@provokateurin provokateurin force-pushed the feature/nextcloud/spreed branch from c53c709 to 904a695 Compare October 28, 2023 06:36
@provokateurin
Copy link
Member Author

I assume nextcloud/spreed#10805 will be merged without objections as well. Just an easy rename of an endpoint to make it easier to know what the endpoint does, so we should include it too

@provokateurin provokateurin force-pushed the feature/nextcloud/spreed branch 2 times, most recently from 6ec2319 to 9658fb8 Compare October 28, 2023 07:15
Leptopoda
Leptopoda requested changes Oct 28, 2023
View reviewed changes
Copy link
Member

@Leptopoda Leptopoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also document everything in packages/nextcloud/lib/src/helpers/spreed.dart

CONTRIBUTING.md Outdated Show resolved Hide resolved
packages/nextcloud/lib/src/helpers/spreed.dart Outdated Show resolved Hide resolved
packages/nextcloud/lib/src/helpers/spreed.dart Outdated Show resolved Hide resolved
packages/nextcloud/lib/src/helpers/spreed.dart Outdated Show resolved Hide resolved
tool/generate-specs.sh Show resolved Hide resolved
tool/generate-specs.sh Outdated Show resolved Hide resolved
packages/nextcloud/lib/src/helpers/spreed.dart Outdated Show resolved Hide resolved
packages/nextcloud/lib/src/helpers/spreed.dart Outdated Show resolved Hide resolved
packages/nextcloud/lib/src/helpers/spreed.dart Show resolved Hide resolved
@provokateurin provokateurin force-pushed the feature/nextcloud/spreed branch from 9658fb8 to 19c9c33 Compare October 28, 2023 17:18
@provokateurin
Copy link
Member Author

The helpers code is now much improved (bitwise operations) and updated (missing enum values). To be fair it was just quickly thrown together when I wrote the Talk prototype, so it was not very good to begin with (which I should have fixed before creating the PR but yeah).

@provokateurin
Copy link
Member Author

The patch with the bug fix is still there because the PR wasn't merged yet, but the one with the small improvement is already in.

@provokateurin provokateurin force-pushed the feature/nextcloud/spreed branch from 19c9c33 to 19a4a50 Compare October 29, 2023 10:40
Leptopoda
Leptopoda requested changes Oct 29, 2023
View reviewed changes
packages/nextcloud/lib/src/helpers/spreed.dart Outdated Show resolved Hide resolved
packages/nextcloud/lib/src/helpers/spreed.dart Outdated Show resolved Hide resolved
packages/nextcloud/lib/src/helpers/spreed.dart Outdated Show resolved Hide resolved
packages/nextcloud/lib/src/helpers/spreed.dart Outdated Show resolved Hide resolved
packages/nextcloud/lib/src/helpers/spreed.dart Outdated Show resolved Hide resolved
packages/nextcloud/lib/src/helpers/spreed.dart Show resolved Hide resolved
packages/nextcloud/lib/src/helpers/spreed.dart Outdated Show resolved Hide resolved
packages/nextcloud/lib/src/helpers/spreed.dart Show resolved Hide resolved
packages/nextcloud/lib/src/helpers/spreed.dart Show resolved Hide resolved
@provokateurin provokateurin force-pushed the feature/nextcloud/spreed branch from 19a4a50 to a2964bd Compare October 29, 2023 11:24
Leptopoda
Leptopoda approved these changes Oct 29, 2023
View reviewed changes
Copy link
Member

@Leptopoda Leptopoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@provokateurin
Copy link
Member Author

Noice, now we just need to wait for nextcloud/spreed#10804 which will probably be merged tomorrow

@provokateurin provokateurin marked this pull request as draft October 29, 2023 11:42
@provokateurin provokateurin force-pushed the feature/nextcloud/spreed branch from a2964bd to 3c9cd2d Compare October 29, 2023 12:39
Leptopoda
Leptopoda requested changes Oct 29, 2023
View reviewed changes
Copy link
Member

@Leptopoda Leptopoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tested #1001 on this branch and it fails.

packages/nextcloud/lib/src/api/spreed.openapi.json Outdated Show resolved Hide resolved
packages/nextcloud/lib/src/api/spreed.openapi.json Outdated Show resolved Hide resolved
@provokateurin
Copy link
Member Author

Will be fixed with nextcloud/spreed#10810. Then we have some ugly empty arrays again (only those appearing in oneOf which was the problematic part), but there is no other way to do this properly.

@provokateurin provokateurin force-pushed the feature/nextcloud/spreed branch from 3c9cd2d to b1530a0 Compare October 29, 2023 17:26
@provokateurin
Copy link
Member Author

@Leptopoda we have another problem now. BuiltList happily validates to the raw value stored in data. So the same problem is still there, but it's now on our side because this shouldn't happen. Do you have an idea how we can work around this? I pushed the current state so you can try it with the correctly generated specs.

@provokateurin
fix(tool): Fix cspell for Dart raw strings
925d8bf 
Signed-off-by: jld3103 <jld3103yt@gmail.com>
@provokateurin
fix(tool): Do not update composer dependencies when generating specs
9955780 
Signed-off-by: jld3103 <jld3103yt@gmail.com>
@provokateurin
fix(nextcloud): Fix waiting on apache in tests
9307bf4 
Signed-off-by: jld3103 <jld3103yt@gmail.com>
@provokateurin provokateurin force-pushed the feature/nextcloud/spreed branch from 790e15c to 9f65aff Compare October 30, 2023 06:24
@provokateurin
feat(tool): Allow patching specs
bd286cf 
Signed-off-by: jld3103 <jld3103yt@gmail.com>
@provokateurin provokateurin force-pushed the feature/nextcloud/spreed branch from 8f357f5 to 295ebec Compare October 30, 2023 09:51
@provokateurin provokateurin marked this pull request as ready for review October 30, 2023 09:51
@provokateurin
Copy link
Member Author

Talk PRs are merged, now we only have the problem with oneOf left.

@Leptopoda Leptopoda mentioned this pull request Oct 30, 2023
Closed
@provokateurin
Copy link
Member Author

To workaround the bugs we will patch the problematic parts of the specs for now (see #1057 (comment) for discussion).

@provokateurin
feat(tool,nextcloud): Add spreed
d4dff34 
Signed-off-by: jld3103 <jld3103yt@gmail.com>
@provokateurin provokateurin force-pushed the feature/nextcloud/spreed branch from 295ebec to d4dff34 Compare October 30, 2023 16:40
@provokateurin provokateurin merged commit c5772fa into main Oct 30, 2023
@provokateurin provokateurin deleted the feature/nextcloud/spreed branch October 30, 2023 18:08
@provokateurin
Copy link
Member Author

🎉

@provokateurin provokateurin mentioned this pull request Oct 30, 2023
Closed
6 tasks
@provokateurin provokateurin mentioned this pull request Nov 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Leptopoda Leptopoda Leptopoda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@provokateurin @Leptopoda